inappropriate centering in IE, again

Posted: Sat Mar 31, 2007 9:00 am

I've just finished upgrading my biggest site to rn2.1

I had an odd issue with some header.html files ... it was reading commented out code! Anyways, I fixed that by deleting the commented out code.

My issue now is about the centering of text in blocks and forums in IE only.
I've read a couple of topics here regarding this issue, but the information seems buried and not complete. Is there something definitive on this? ie: exactly what needs to be done in which files?

Thanks

registered · Posted: Sat Mar 31, 2007 10:37 am

I don't think there is anything definitive, it is pretty theme dependent. I added align="left" to several key TD tags in my theme.

Posted: Sat Mar 31, 2007 1:17 pm

I wish I could be more definitive too but that problem plagued us in getting the themes ready for 2.10. It seems like if there is one center attribute in IE it kind of "pollutes" the whole page and inappropriately centers material that shouldn't be centered. Where we found it we either fixed it like Gremmie said by adding left aligns or else we removed center tags where we could. This took place over a period of months so there is no single repository of fixes for the centering problems; it's theme specific.

If you can point out specific themes that still have this problem we can put them into the bug tracker and eventually come up with a fix.

Posted: Sat Mar 31, 2007 5:39 pm

I fixed the blocks.html by putting an align=left in the <td> before the output of content.

I'm still having issues with the news stories on the home page and the forums and the recent forums block. So many <td>s and it isn't obvious which one outputs the text, particularly for the forums.

fisubsilversh
spacepilot3k

Posted: Sat Mar 31, 2007 8:28 pm

Yes, the td's drove us crazy in 2.10 development too. If you look at the code for the new themes you'll see that we tried to line them up better by using indentation for tables, trs and tds and then similar indentation as they were closed. The previous way of writing the themes code made it very difficult to debug, as you've seen. It's still far from easy.

I can't say anything about fisubsilversh or spacepilot3k. I think personally that this whole crazy quilt of theme architecture has to go. I know that I'm in a minority but my opinion is that it's just impossible to support. It's entirely possible that some changes in the core could affect something in the themes, there is not a clear and distinct line between where the core ends and the theme begins. Without sitting for a day or two and debugging those themes it's impossible to tell.

Do you experience similar problems with the themes included in RN 2.10?

Posted: Sun Apr 01, 2007 8:15 am

I fixed the forums alignment by editing overall_header.tpl, in the style part of the file...

.postbody{text-align:left; font-size:12px;line-height:125%}

and the forum index...

.row1{text-align:left; background:#eaedf4}

I'm working through this. The biggest issue I have is with the themes that have their forums style sheets buried in the overall_header.tpl and not in a forums.css file.

I've fixed messages in style.css
.content {BACKGROUND: none; COLOR: #006699 FONT-SIZE: 10px; FONT-FAMILY: Verdana, Helvetica; text-align:left}

But I can't figure out where to fix the news stories. The wysiwyg editor is fabulous... it's been ages since I wanted one on this particular site. If I edit a story in IE then I can left justify the text and it works. But left is a default in FF. So, I don't know what's going on. (situation nominal. Wink

) But there must be a td I can fix in one of the themes story files ... I just haven't found it yet.

The themes I've tried with rn2.1 seem to work fine. It's only my older custom themes that need tweeking. But tweek I will, because it's all worth it... rn2.1 is so wonderful.

registered · Posted: Sun Apr 01, 2007 10:34 am

Ok, so your theme does not have a story_home.html and story_page.html? So many ways to cut-and-slice these !@#$% themes and, of course, there were no real standards... You might have to look in theme.php then at these two functions to find out how these are getting formatted:

function themeindex
function themearticle

These are what do it for the news stories... Now, they may be including or opening/reading other files, but start there as that is where the trail begins...

Posted: Sat Apr 14, 2007 10:35 am

I actually fixed it by adding an align="left" attribute to my header which took care of virtually everything on the main page.

To correct the forums I edited the overall_header.tpl.

I also noticed that the cells in the forums themselves show fine in Firefox but not in IE. In these areas I had to insert spacer images as setting a locked pixel width didn't seem to work for whatever reason.

Regular Joined: Dec 28, 2004 Posts: 94

Sorry its taken me a while to get back.

I've found that for many themes, align="center" is being used in the first lines of header.html in themes folder.

eg. phpib2 theme

Code:

<table class="bodyline" width="100%" cellspacing="0" cellpadding="0" border="0"> 


   <tr> 


      <td align="center" valign="top">

the align="center" is being used for the whole page!!!

Just remove it. Everthing settles back to normal. Very Happy

Code:

<table class="bodyline" width="100%" cellspacing="0" cellpadding="0" border="0"> 


   <tr> 


      <td valign="top">

Hope this helps Smile

New Member Joined: Feb 05, 2006 Posts: 24

could this be why my news posts in my custom theme is looking stupid with everything being centered with a 6" gap on eithere side of the news post. Well i notice it more as I am using a widescreen but here is my url.

http://www.farstar-fear.com

here is a picture how it looks on my screen

http://www.farstar-fear.com/images/themeissue.jpg

however if i use sya fibsauce it looks normal

http://www.farstar-fear.com/images/nothemeissue.jpg

New Member Joined: Sep 13, 2006 Posts: 6

same is and with me
Only registered users can see links on this board! Get registered or login!

Posted: Sat Jun 09, 2007 12:27 am

Gepa and noord,

The fix above for header.html should sort your problem out.

Please leave feedback if it does.

Trub

Posted: Wed Jun 13, 2007 7:06 pm

A quick update to this problem.

Noord had a Div tag centering at the end of his header.html file that was'nt closed.

Making the rest of his theme all centered.

So the problem does differ between themes.

If anyone still has an issue, try to look for align="center" in your header.html and experiment with removing one at a time until you find the answer.

TTFN

Trub

Regular Joined: Nov 27, 2005 Posts: 58

Fixed news articles and forum posts in SubBlack3d - they were centering text

In Story_home.html, I had to set this line to left


<tr>
<td class="story_border" align="left">

EDIT: Fixed forum centering in SubBlack3d

In viewtopic_body.tpl

Changed this:

<tr>
<td colspan="2">{postrow.MESSAGE}{postrow.SIGNATURE}{postrow.EDITED_MESSAGE}
 
</td>
</tr>

To This:

<tr>
<td colspan="2" align="left">{postrow.MESSAGE}{postrow.SIGNATURE}{postrow.EDITED_MESSAGE}
 
</td>
</tr>

Now the only thing I have yet to figure out is why my news articles have no background in Firefox - they go right through to the entire site background. The background is there in IE - go figure.

Client Joined: Jan 29, 2004 Posts: 624

Trubador wrote:

A quick update to this problem.

Noord had a Div tag centering at the end of his header.html file that was'nt closed.

Making the rest of his theme all centered.

So the problem does differ between themes.

If anyone still has an issue, try to look for align="center" in your header.html and experiment with removing one at a time until you find the answer.

TTFN

Trub

Your ideas got my fiblack theme uncentered, how about the Forums index? Should I look in the viewforum_body.tpl for <td> centered tags? Thanks

Posted: Sat Oct 13, 2007 1:53 am

I posted mine in the wrong forum :/

Here are the edits to correct the theme display( I will verify them in short time, to make sure I did not miss something) for the Coldsteel theme, minus custom and general theme edits (such as showing blocks, hiding blocks etc...)

Tested on RN 2.10.01 and phpBB ported to nuke version 2.022.

In the folder/directory pathtonuke\themes\Coldsteel\
Edit the file blocks.html

Look for:

Code:

<td bgcolor="f1f1f1"><font class="content">$content</font></td>

Replace with:

Code:

<td align=left bgcolor="f1f1f1"><font class="content">$content</font></td>

Save file.

In the folder/directory pathtonuke\themes\Coldsteel\forums\
Edit the file index_body.tpl

Look for:

Code:




      <!-- BEGIN catrow -->


        <div align="center">


          <table width="100%" cellpadding="2" cellspacing="0" border="0" class="forumline">


            <tr> 


              <td background="themes/Coldsteel/forums/images/catbg2.gif" colspan="6" height="28"><span class="cattitle">:: 


                <a href="{catrow.U_VIEWCAT}" class="cattitle">{catrow.CAT_DESC} 


                </a>::</span></td>


            </tr>


          </table>


        </div>


        <div align="center">


          <table width="100%" cellpadding="2" cellspacing="1" border="0" class="forumline">


            <tr> 


              <th colspan="2" class="thCornerL" height="25" nowrap>&nbsp;{L_FORUM}&nbsp;</th>


              <th width="50" class="thTop" nowrap>&nbsp;{L_TOPICS}&nbsp;</th>


              <th width="50" class="thTop" nowrap>&nbsp;{L_POSTS}&nbsp;</th>


              <th class="thTop" nowrap>&nbsp;{L_LASTPOST}&nbsp;</th>


            </tr>


            <!-- BEGIN forumrow -->


            <tr> 


              <td class="row1" align="center" valign="middle" height="40"><img src="{catrow.forumrow.FORUM_FOLDER_IMG}" width="46" height="25" alt="{catrow.forumrow.L_FORUM_FOLDER_ALT}" title="{catrow.forumrow.L_FORUM_FOLDER_ALT}" /></td>


              <td class="row1" width="100%" height="40"><span class="forumlink"> 


                <a href="{catrow.forumrow.U_VIEWFORUM}" class="forumlink">{catrow.forumrow.FORUM_NAME}</a><br />


                </span> <span class="genmed">{catrow.forumrow.FORUM_DESC}<br />


                </span></td>


              <td class="row2" align="center" valign="middle" height="40"><span class="gensmall">{catrow.forumrow.TOPICS}</span></td>


              <td class="row2" align="center" valign="middle" height="40"><span class="gensmall">{catrow.forumrow.POSTS}</span></td>


              <td class="row2" align="center" valign="middle" height="40" nowrap> 


                <span class="gensmall">{catrow.forumrow.LAST_POST}</span></td>


            </tr>


            <!-- END forumrow -->


            <tr> 


              <td background="themes/Coldsteel/forums/images/catbg3.gif" colspan="6" height=25>&nbsp; 


            </tr>


            <!-- END catrow -->

Change to:

Code:




        <!-- BEGIN catrow -->


        <div align="left">


          <table width="100%" cellpadding="2" cellspacing="0" border="0" class="forumline">


            <tr> 


              <td background="themes/Coldsteel/forums/images/catbg2.gif" colspan="6" height="28"><span class="cattitle">:: 


                <a href="{catrow.U_VIEWCAT}" class="cattitle">{catrow.CAT_DESC} 


                </a>::</span></td>


            </tr>


          </table>


        </div>


        <div align="left">


          <table width="100%" cellpadding="2" cellspacing="1" border="0" class="forumline">


            <tr> 


              <th align ="center" colspan="2" class="thCornerL" height="25" nowrap>&nbsp;{L_FORUM}&nbsp;</th>


              <th width="50" class="thTop" nowrap>&nbsp;{L_TOPICS}&nbsp;</th>


              <th width="50" class="thTop" nowrap>&nbsp;{L_POSTS}&nbsp;</th>


              <th align ="center" class="thTop" nowrap>&nbsp;{L_LASTPOST}&nbsp;</th>


            </tr>


            <!-- BEGIN forumrow -->


            <tr> 


              <td class="row1" align="center" valign="middle" height="40"><img src="{catrow.forumrow.FORUM_FOLDER_IMG}" width="46" height="25" alt="{catrow.forumrow.L_FORUM_FOLDER_ALT}" title="{catrow.forumrow.L_FORUM_FOLDER_ALT}" /></td>


              <td class="row1" width="100%" height="40"><span class="forumlink"> 


                <a href="{catrow.forumrow.U_VIEWFORUM}" class="forumlink">{catrow.forumrow.FORUM_NAME}</a><br />


                </span> <span class="genmed">{catrow.forumrow.FORUM_DESC}<br />


                </span></td>


              <td class="row2" align="center" valign="middle" height="40"><span class="gensmall">{catrow.forumrow.TOPICS}</span></td>


              <td class="row2" align="center" valign="middle" height="40"><span class="gensmall">{catrow.forumrow.POSTS}</span></td>


              <td class="row2" align="center" valign="middle" height="40" nowrap> 


                <span class="gensmall">{catrow.forumrow.LAST_POST}</span></td>


            </tr>


            <!-- END forumrow -->


            <tr> 


              <td background="themes/Coldsteel/forums/images/catbg3.gif" colspan="6" height=25>&nbsp; 


            </tr>


            <!-- END catrow -->

Save file.