Couple of dynamic_titles suggestions

technocrat · Involved Joined: Jul 07, 2005 Posts: 492

No it will work, but thats because registered globals are turned on. But I would get in the habit of declaring all your globals in included files, just to make sure that something unexpected doesnt happen.

Like I said they are suggestions nothing else. I am just happy you guys secured it. You could hack this really easily in it's original state.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4640

Thanks - definitely great suggestions! Have you looked at performance impact of using freeresult?

Raven · Posted: Fri Mar 16, 2007 8:19 am

I don't run register_globals on, as a host, and I add register_globals off to my .htaccess just as added insurance.

technocrat wrote:

Second add $db->sql_freeresult();

According to this post,

Only registered users can see links on this board!
Get registered or login to the forums!

Using this function may actually increase the amount of memory used. In my case, the script used 208 bytes less memory when *not* using mysql_free_result().
Check for yourself: call memory_get_usage() at the end of the script.

It is not recommended to use this with PHP 4.x

Raven · Posted: Fri Mar 16, 2007 8:51 am

I inadvertently deleted the first 2 posts of this thread! Rather than try to put them back in order, I'll just repost them here.
-----------------------------------------------------------------------------------------

Technocrat
Posted: Thu Mar 15, 2007 9:47 am
These are just a few suggestions, so you can do what ever with them.

First I would change all the if statements to else if. There is no reason to parse all the other if statements when its not possible to be in two areas at once.

Second add $db->sql_freeresult(); to your queries or add an unbuffered fetch to your db class. It will help keep down the memory usage. You should probably get in the habit of adding it everywhere.

Third $newpagetitle = $slogan; you do not have it globally declared except in the if news statement.
-----------------------------------------------------------------------------------------
KGuske
Posted: Thu Mar 15, 2007 8:39 pm
Interesting ideas. I haven't tested the dynamic titles, really, but I did look at the code and I'm not sure the variables need to be globally declared. Did you verify a problem, technocrat?

montego · Posted: Fri Mar 16, 2007 9:10 am

Yeah, I don't have register globals on either and I am running 2.10. Odd.

I"ll take a look at your suggestions, especially the else if. I agree with you that from an execution point (rather than parse), it would be quicker.

I have added this to my "to-do" as I have also released this to the public so the non-RN'ers could benefit.

Gremmie · Posted: Fri Mar 16, 2007 9:33 am

I'm confused about something. You guys may not have register globals turned on, but Nuke essentially overrides you with import_request_variables(). Unless you guys rewrote all of Nuke to use $_POST, $_GET, etc.

technocrat · Involved Joined: Jul 07, 2005 Posts: 492

Sure you "inadvertently" deleted it ROTFL

Well if it doesn't make a difference in 4 then it does in 5. I took the memory usage down 1/3 by adding freeresults in a lot of places, like mainfile, and sentinel. Plus if you look at the code for phpbb v3 db class they free all the db queries. Not that they are the perfect coders but they generally do good work.

Raven · Posted: Fri Mar 16, 2007 9:55 am

technocrat,

Yes, in PHP 5 it seems it does make a difference. Especially if you use mysqlI

Guardian2003 · Posted: Sat Mar 17, 2007 8:02 am

So there would be some future benefit by perhaps setting a constant in rnconfig.php to indicate whether the user was utilising PHP 5.x.x and then wrapping the freeresult in an if isset so it only gets execute the constant is set?

Raven · Posted: Sat Mar 17, 2007 8:23 am

Actually, it would be easier to just do an internal test rather than add another setting Smile

gotcha · Regular Joined: Mar 14, 2005 Posts: 70

I think it would be nice to make it work similar to the way GT includes the url rewrites.
So if there is a file "dynamic_titles/DT-Forums.php" include it and make a $GLOBAL variable that contains the dynamic title... if the $GLOBAL is empty have it revert to the default $sitename $pagetitle.
Not sure if it will be much faster than using a bunch of if else statements, but it will certainly be alot cleaner and would give developers a chance to include it in their modules Smile

montego · Posted: Sun Mar 18, 2007 9:57 am

gotcha, the concept is a sound one. We would have to run some tests to see if the If-elseif length is really too long to warrant the additional disk reads. My gut tells me that there is probably some "breaking point", where it might start being the more efficient approach... but, to quote a famous Quality guru Deming: "In God I trust, everyone else, show me the data..." Smile

gotcha · Regular Joined: Mar 14, 2005 Posts: 70

Maybe if the dynamic title code was included in the GoogleTap/GT-*.php file it would save the extra disk read and eliminate the if $name ==. I know in GT-nextgen(haven't tried yours yet) the GT-*.php file is included before the head(); function is called. I am actually using the method from my last post but I haven't really done any speed comparisons yet.