FCKeditor 2.6 - need input on one design question

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

One of the changes with FCKeditor 2.6 that will impact upgrades is that the directory names have changed to all lower case. This causes problems on operating systems that are case sensitive AND previously uploaded files to the includes/FCKeditor/uploads/Image, includes/FCKeditor/uploads/Flash, includes/FCKeditor/uploads/File, or includes/FCKeditor/uploads/Media directories, since these would now become: includes/fckeditor/uploads/image, includes/fckeditor/uploads/flash, includes/fckeditor/uploads/file, and includes/fckeditor/uploads/media respectively.

Since this impacts our ability to upgrade in the future, it makes sense to move the uploads out of this directory. I thought about putting it in the /images/ directory, but since there are more than just images, I didn't want to do that. My next choice was /resources/ and we spent several days testing this (it worked fine on Linux, but failed on Windows). Why? I first thought there might be an issue with _SERVER['PHP_SELF'], but finally figured out that Windows protects the directory name resources!

The question: what to name the folder? Some suggestions:
/files/
/res/
/uploads/

I'm leaning toward /res/ - short for resources, which is more descriptive than files, but wanted to get input before moving ahead. What would you prefer?

Gremmie · Posted: Mon Apr 21, 2008 8:14 pm

Does it upload more than images? How about /media?

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

It will have the following subdirectories:
file
flash
image
media

The default in FCKeditor is /userfiles/ but that's a subdirectory / folder of fckeditor, which makes upgrading more difficult.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

How about a default, and the ability to override this by adding a variable in config.php / rnconfig.php ?

But the question remains, what should be the default?

/files/
/res/
/uploads/
?

jakec · Posted: Tue Apr 22, 2008 5:59 am

Personally I would choose uploads. JMO

montego · Posted: Tue Apr 22, 2008 6:47 am

Either "files" or "uploads" sounds good to me and I do like the idea of a configuration switch. You know me... love making this easy. Laughing

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

uploads or files sounds good to me too

guidyy · Worker Joined: Nov 22, 2004 Posts: 206 Location: Italy

files or uploads are fine for me too.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

OK. I'll go with uploads. I will make a version available to those who wish to test for a week before adding to SVN.

jestrella · Posted: Tue Apr 22, 2008 11:45 am

definitely uploads is the best choice for this... even media can be a good one for this purpose.

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

looking forward to playing with the ajax inline editor

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

PM sent. Enjoy...

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

montego · Posted: Wed Apr 23, 2008 6:55 am

kguske wrote:

PM sent. Enjoy...

Holding out on me? lol....

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

Of course not...PM sent.

montego · Posted: Wed Apr 23, 2008 11:38 am

sorry, was just kidding. BTW, if I can get up enough energy today (home sick), I am planning on testing out the revised directory naming. I'll let you know if I find anything else too.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

No problem. My main concern after testing is that changes to the documentation (namely, readme.txt and upgrade.txt). Because the changes aren't trivial, I want to make sure it's as clear as possible, so I definitely welcome suggestions for improving that Smile

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

I've installed it on a few sites, and it seems to be working well. I think I'll add it to the RN SVN, unless there are objections...

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

I was hoping to get it installed on a site yesterday but the whole week-end went by way to quickly.

montego · Posted: Tue Apr 29, 2008 5:17 am

kguske, I've added issue#967 for the upgrade.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

It's been added to SVN.

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

Excellent news.

kguske · Site Admin Joined: Jun 04, 2004 Posts: 4853

I really like the DHTML popups - you don't have to resize the Windows in FireFox anymore, and it seems much faster to add images, links, etc.

Guardian2003 · Site Admin Joined: Aug 28, 2003 Posts: 4824

Yes, that is one of the features I was really looking forward to. I'm getting desperate now to get it installed but *things* keep getting in the way Sad

Edit: fix my ridiculous typo(s)

montego · Posted: Thu May 01, 2008 5:19 am

So odd. I am on the latest SVN working copy and cannot use either the Browse or Upload options. This is on XAMPP 1.6.4 under PHP5 and on Windows XP Professional SP2. I am curious kguske what you are running this same build under since it is working for you.