How to GT Old Articles Block

Raven · Posted: Fri Sep 10, 2004 10:47 pm

I think I have resolved the mystery Smile

I had noticed that Bill's Old Articles block was working so I got to snooping around in his code and tried a few things and saw that this works for me. This is v6.9 nuke, but I don't think much has changed. This should also work for NextGEN. In block-Old_Articles.php find this code

Code:

if (isset($cookie[4])) { $r_options .= "&mode=$cookie[4]"; }
if (isset($cookie[5])) { $r_options .= "&order=$cookie[5]"; }
if (isset($cookie[6])) { $r_options .= "&thold=$cookie[6]"; }

and change it to

Code:

if (!isset($cookie[4])) { $r_options .= ".html"; }
if (isset($cookie[4])) { $r_options .= "-$cookie[4]"; }
if (isset($cookie[5])) { $r_options .= "-$cookie[5]"; }
if (isset($cookie[6])) { $r_options .= "-$cookie[6].html";}

Then find this code

Code:

if($time2==$datetime2) {
$boxstuff .= "<tr><td valign=\"top\"><big>·</big></td><td> <a href=\"modules.php?name=News&file=article&sid=$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
} else {
if($a=="") {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"modules.php?name=News&file=article&sid=$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
 $a = 1;
 } else {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"modules.php?name=News&file=article&sid=$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
 }
}

and change it to

Code:

if($time2==$datetime2) {
$boxstuff .= "<tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
} else {
if($a=="") {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
 $a = 1;
 } else {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\" $total_text>$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
 }
}

64bitguy · Posted: Sat Sep 11, 2004 6:18 am

Hi Raven!

Thanks for the great post. I wish I had this a couple of nights ago, as you know I've been going through all of my blocks and converting them for GoogleTap (which has been just a TON of fun... please detect the note of sarcasm!)

I only found issue with a single aspect of your code; the exclusion of the fix for the "Older Articles" button.

As for the original code included with Chatserv's 7.4 Patched 2.5, I found a bug that I have also corrected and displayed below. The problem was that (with your code) my site displayed comments next to each article as () without any numbers in the parenthesis.

In my original Chatserv patched 2.5 code, (for some reason) I didn't have either the comments, nor the (). After a review of my code I found this:

Code:

if ($articlecomm == 1) {
$comments = "($comments)";
} else {
$comments = "";
}

Obviously, that presented a problem, so I fixed it. To be honest, I never noticed the problem until you presented your solution above, which made the () show up without anything in them. That's when it jumped out at me.

I'm not sure that my version of this fix is any more or any less elegant than what you presented above (I know me, my version is probably less elegant), but please feel free to checkout my final version of code. The output (compared to your solution) looks identical now that both solutions are appropriately patched. I would like to know which way is the most condusive to performance and functionality.

Here's the code the way that I had re-written it.

Code:

<?php

/************************************************************************/
/* PHP-NUKE: Web Portal System */
/* =========================== */
/* */
/* Copyright (c) 2002 by Francisco Burzi */
/* http://phpnuke.org */
/* */
/* Patched by Steph http://64bit.us for GoogleTap on */
/* September 9, 2004 @ 2:24AM-EST */
/* Comments fixed, all links tested & verified */
/* */
/* This program is free software. You can redistribute it and/or modify */
/* it under the terms of the GNU General Public License as published by */
/* the Free Software Foundation; either version 2 of the License. */
/************************************************************************/
/* Additional security & Abstraction layer conversion */
/* 2003 chatserv */
/* http://www.nukefixes.com -- http://www.nukeresources.com */
/************************************************************************/

if (eregi("block-Old_Articles.php", $_SERVER['SCRIPT_NAME'])) {
Header("Location: index.php");
die();
}

global $locale, $oldnum, $storynum, $storyhome, $cookie, $categories, $cat, $prefix, $multilingual, $currentlang, $db, $new_topic, $user_news, $comments;

if ($multilingual == 1) {
if ($categories == 1) {
$querylang = "where catid='$cat' AND (alanguage='$currentlang' OR alanguage='')";
} else {
$querylang = "where (alanguage='$currentlang' OR alanguage='')";
if ($new_topic != 0) {
 $querylang .= " AND topic='$new_topic'";
}
}
} else {
if ($categories == 1) {
 $querylang = "where catid='$cat'";
} else {
$querylang = "";
if ($new_topic != 0) {
 $querylang = "WHERE topic='$new_topic'";
}
}
}
if (isset($cookie[3]) AND $user_news == 1) {
$storynum = $cookie[3];
} else {
$storynum = $storyhome;
}
$boxstuff = "<table border=\"0\" width=\"100%\">";
$boxTitle = _PASTARTICLES;
$result = $db->sql_query("SELECT sid, title, time, comments FROM ".$prefix."_stories $querylang ORDER BY time DESC LIMIT $storynum, $oldnum");
$vari = 0;

$r_options = "";
if (!isset($cookie[4])) { $r_options .= ".html"; }
if (isset($cookie[4])) { $r_options .= "-$cookie[4]"; }
if (isset($cookie[5])) { $r_options .= "-$cookie[5]"; }
if (isset($cookie[6])) { $r_options .= "-$cookie[6].html"; }

while ($row = $db->sql_fetchrow($result)) {
$sid = intval($row['sid']);
$title = stripslashes($row['title']);
$time = $row['time'];
$comments = $row['comments'];
$see = 1;
setlocale(LC_TIME, $locale);
ereg ("([0-9]{4})-([0-9]{1,2})-([0-9]{1,2}) ([0-9]{1,2}):([0-9]{1,2}):([0-9]{1,2})", $time, $datetime2);
$datetime2 = strftime(""._DATESTRING2."", mktime($datetime2[4],$datetime2[5],$datetime2[6],$datetime2[2],$datetime2[3],$datetime2[1]));
$datetime2 = ucfirst($datetime2);
if ($comments <> 0) {
$comments = "$comments";
} else {
$comments = "0";
}
if($time2==$datetime2) {
$boxstuff .= "<tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\">$title</a> ($comments)</td></tr>\n";
} else {
if($a=="") {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\">$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
 $a = 1;
} else {
 $boxstuff .= "<tr><td colspan=\"2\">$datetime2</td></tr><tr><td valign=\"top\"><big>·</big></td><td> <a href=\"article$sid$r_options\">$title</a> ($comments)</td></tr>\n";
 $time2 = $datetime2;
}
}
$vari++;
if ($vari==$oldnum) {
if (isset($cookie[3])) {
 $storynum = $cookie[3];
} else {
 $storynum = $storyhome;
}
$min = $oldnum + $storynum;
$dummy = 1;
}
}

if ($dummy == 1 AND is_active(Stories_Archive)) {
$boxstuff .= "</table> <a href=\"archive.html\"><center>Browse Entire Archive</center></a>\n";
} else {
$boxstuff .= "</table>";
}

if ($see == 1) {
$content = $boxstuff;
}

?>

Raven · Posted: Sat Sep 11, 2004 8:49 am

I did not have that problem because I don't use that code in v6.9 Smile

chatserv · Posted: Sun Sep 12, 2004 7:44 pm

Could you clarify what exactly happened when you had comments set to "" instead of "0" like you do now, by the way and for the record that is original code and not anything i came up with, i compared the 2.5 block for 7.4 to a "clean" block from 6.5 and the code is the same on both.

Raven · Posted: Sun Sep 12, 2004 7:56 pm

Raven wrote:

I did not have that problem because I don't use that code in v6.9 Smile

For clarification, what I meant was that code is not in my block code so it never was a factor.

64bitguy · Posted: Mon Sep 13, 2004 5:50 am

chatserv wrote:

Could you clarify what exactly happened when you had comments set to "" instead of "0" like you do now, by the way and for the record that is original code and not anything i came up with, i compared the 2.5 block for 7.4 to a "clean" block from 6.5 and the code is the same on both.

Cool. I wouldn't know as I don't have any versions prior to 7.0, I was just pointing out that I based my fixes and re-write on the latest patched version (unaltered code distributed as part of the "Patched" series of solutions). It wasn't meant as a shot, but rather to point out that a large number of people probably have the code the way I have it.

I did notice that raven's (6.9?) version using "search more" archives is substantially different; in that it fails to have the monthly menu and values not showing up in the default destination; however, his "search more" results equate to the user being taken to an untapped destination of