Links back to article after rating is broken

registered · Posted: Sun Apr 01, 2007 12:21 pm

Thanks to Susann for finding and reporting this!

Basically, what is happening is that when an article is rated on, the "Back to Article" link is broken. It is always using a story id of "0". There are errant "&;" instead of "&" in the Header() functions.

Here is the fix if you are interested in fixing this:

=== OPEN ===

modules/News/index.php

=== FIND ===

Code:




        if ($a == 1) {


            Header('Location: modules.php?name=News&op=rate_complete&;sid='.$sid.'&;rated=1');


        } else {


                $result = $db->sql_query('update '.$prefix.'_stories set score=score+'.$score.', ratings=ratings+1 where sid=\''.$sid.'\'');


                $info = base64_encode("$rcookie$sid:");


                setcookie('ratecookie',"$info",time()+3600);


                update_points(7);


                Header('Location: modules.php?name=News&op=rate_complete&;sid='.$sid.$r_options);


        }

=== REPLACE WITH ===

Code:




        if ($a == 1) {


            Header('Location: modules.php?name=News&op=rate_complete&sid='.$sid.'&rated=1');


        } else {


                $result = $db->sql_query('update '.$prefix.'_stories set score=score+'.$score.', ratings=ratings+1 where sid=\''.$sid.'\'');


                $info = base64_encode("$rcookie$sid:");


                setcookie('ratecookie',"$info",time()+3600);


                update_points(7);


                Header('Location: modules.php?name=News&op=rate_complete&sid='.$sid.$r_options);


        }

=== DONE ===

registered · Posted: Sun Apr 01, 2007 2:48 pm

Thanks!