Author |
Message |
helidoc
Hangin' Around

Joined: Jul 09, 2006
Posts: 49
|
Posted:
Tue Mar 13, 2007 12:25 pm |
|
First off I want to say thanks to everyone that worked on the project, my three sites run much smoother and I've had nothing but positive feedback so far!!
Currently 2 of my sites use subBlack3dBlue from nukemods for the default themes tho at the moment I've switched to fisubice to keep with the changes to RN, my question being is what changes were made would love to get subBlack3dBlue back up and running on RN again.
Thanks again!! |
|
|
|
 |
jakec
Site Admin

Joined: Feb 06, 2006
Posts: 3048
Location: United Kingdom
|
Posted:
Tue Mar 13, 2007 1:49 pm |
|
So are you saying the theme is not working with RN 2.10? |
|
|
|
 |
helidoc

|
Posted:
Tue Mar 13, 2007 2:44 pm |
|
It works for the most part, havn't recieved any errors on my local machine tho there are some graphics that seem to be messed up a lil, for instance if you go to the forums listing it's aligning the forum names center instead of left which throws the layout off a bit as well as a few other items in the forums that dont align correctly. Thats what I have noticed so far... |
|
|
|
 |
jakec

|
Posted:
Tue Mar 13, 2007 2:56 pm |
|
That's odd, the theme usually controls the look of the site and not nuke.
This may be one for fkelly, as he's done a lot of work on the stock themes and it's maybe something he's encountered before. |
Last edited by jakec on Tue Mar 13, 2007 2:57 pm; edited 1 time in total |
|
|
 |
fkelly
Former Moderator in Good Standing

Joined: Aug 30, 2005
Posts: 3312
Location: near Albany NY
|
Posted:
Tue Mar 13, 2007 2:57 pm |
|
Does subblack... whatever, have it's own Forums template?
The changes we made to themes were mostly for performance (going to single quotes and concatenation rather than double quotes) and for html 4.01 compliance (quoting attributes, adding closes (/) and alts on image tags and the like. There may also need to be a change in the header function to call the ads function ... I'm not positive if that would be required ... probably it would work without it. If subblack... is structured similarly to the Helius theme from Nukemods that I looked at then you might find some success in lining it up next to fisubice and modeling any changes on that.
I might be wrong, but I don't recall us doing any work on the Forum templates that would cause this. |
|
|
|
 |
jakec

|
Posted:
Tue Mar 13, 2007 2:59 pm |
|
Oh there he is.  |
Last edited by jakec on Tue Mar 13, 2007 4:46 pm; edited 1 time in total |
|
|
 |
fkelly

|
Posted:
Tue Mar 13, 2007 3:08 pm |
|
Great timing Jakec
Oh gosh, I left a right parenthesis out in my previous post, I'll never compile. Here it is:
")". |
|
|
|
 |
helidoc

|
Posted:
Tue Mar 13, 2007 3:16 pm |
|
fkelly thanks for the suggestions, I dont know about it being simular to Helius or not I don't have that. I'll try lining it up next to fisubice and see what success I have with that. I do believe it has it's own template (still trying to learn alot). What I do know is there is a differance on it from 2.02 to 2.10 (have another site I have yet to update with 2.10) I'm using it as a basis of comparison. |
|
|
|
 |
fkelly

|
Posted:
Tue Mar 13, 2007 3:25 pm |
|
If you look in the themes directory under the subblack3dblue theme and there is a Forums subdirectory there, then it has a Forums template. If not it would use the default subsilver template for forums.
If the differences you are seeing are in the Forums area I'm afraid someone else will have to help or you'll have to resolve it yourself. I just don't know much about how the Forums templates are put together or what would be causing a difference from 2.02 to 2.10. |
|
|
|
 |
helidoc

|
Posted:
Tue Mar 13, 2007 3:41 pm |
|
Thanks for the tips It does have it's own template so I get to go digging thanks for taking your time to reply! There is a differance on how it renders between 2.02 and 2.10 (but no errors) so anything I find I'll post here as I'm sure I won't be the first to run into this.
On a side note I'm shuddering to attempt to convert an autothemes site  |
|
|
|
 |
wiz
Involved


Joined: Oct 09, 2006
Posts: 413
Location: UK
|
Posted:
Tue Mar 13, 2007 3:53 pm |
|
I use SubBlack3dBlue on one of my sites as default.
Currently i have not upgraded the RN yet on that site. Feel free Fkelly or anyone else to peruse the theme at the following addy..
Only registered users can see links on this board! Get registered or login!
I would be interested to keep tabs on this topic before i upgrade that site
Cheers
WIZ |
|
|
|
 |
fkelly

|
Posted:
Tue Mar 13, 2007 5:17 pm |
|
Why thanks Wiz, lol. I did some work on the Helius theme, converting it to RN2.10 and making some of the "standard" changes we were making to all themes as part of it. I did that because I was interested in seeing what 3d party themes looked like internally and whether there were any significant differences structurally. My conclusion is that there aren't.
The problem, as I see it, is with the whole themes architecture. There is just way too much duplication of code and when you try to fix things you have to apply the same or similar fixes over and over again with subtle variations that making testing a nightmare.
I guess this is my way of saying that I'm not going to continue chasing after additional third party themes but instead focus on a proposal for an alternative (but compatible) architecture for the next release. Meanwhile what I'd suggest if you want to debug a theme is to take one of the compliant ones (see my recent post listing compliant themes) and line up your theme next to it in an editor and just go thru and make the adjustments in a test system. It really doesn't take a coding wizard to do this cause if it did Raven never would have trusted me with the task for 2.10.  |
|
|
|
 |
wiz

|
Posted:
Tue Mar 13, 2007 6:22 pm |
|
fkelly wrote: |
I guess this is my way of saying that I'm not going to continue chasing after additional third party themes but instead focus on a proposal for an alternative (but compatible) architecture for the next release. |
The next release
Calm down its only been out a day or so  |
|
|
|
 |
wiz

|
Posted:
Thu Mar 15, 2007 12:40 pm |
|
Ok i have upgraded the above site to 2.1 now and it runs fine with subBlack3dBlue |
|
|
|
 |
helidoc

|
Posted:
Thu Mar 15, 2007 3:52 pm |
|
wiz wrote: | Ok i have upgraded the above site to 2.1 now and it runs fine with subBlack3dBlue |
Hrm.. Just peeked at your site wiz and it appears your having the same issue I am with the forums listing Forum names etc being centered instead of aligned right or left. Just got back in from a run and was going to start digging into it. |
|
|
|
 |
wiz

|
Posted:
Thu Mar 15, 2007 3:55 pm |
|
They are centered because i specifically centered them, using html in the forum title. As of yesterday they were not. |
|
|
|
 |
helidoc

|
Posted:
Thu Mar 15, 2007 3:58 pm |
|
Hrm ok my bad Mine are centered on thier own. |
|
|
|
 |
wiz

|
Posted:
Thu Mar 15, 2007 4:09 pm |
|
No Problem. However my site is probably not the best place to look right now. Tried installing Coppermine and it trashed my db...
Back to the drawing board |
|
|
|
 |
helidoc

|
Posted:
Thu Mar 15, 2007 4:12 pm |
|
Dumb question but someplace for me to look, what browser do you use ? |
|
|
|
 |
helidoc

|
Posted:
Thu Mar 15, 2007 4:21 pm |
|
Well answered my own question, looks like this is a IE issue looks fine in firefox Dang I hate MS at times since I have users that use both that complicates things  |
|
|
|
 |
helidoc

|
Posted:
Fri Mar 16, 2007 12:20 am |
|
Well found some solutions to this For some reason there were center tags in various tpl files, overall_header, overall_footer and index_body to name a few that in RN2.02 were being ignored in both IE6 and IE7 but in RN2.10 were not. Firefox still ignores these tags in RN2.10
This theme was originally developed for phpbb and after several versions ported to phpnuke currently I'm going over it and making an attempt to clean it up a bit. Cosmeticly I have it close to what it was in RN2.02 but loading much faster with RN2.10 which is what I was shooting for.  |
|
|
|
 |
wiz

|
Posted:
Fri Mar 16, 2007 6:23 am |
|
Mine does actually centre now, without adding the html tags..Sorry Helidoc
I apologise but due to me restoring my db from a backup, your post on my forums is lost, however your account is ok. |
|
|
|
 |
salongaopm
Hangin' Around

Joined: Apr 30, 2007
Posts: 41
|
Posted:
Tue May 29, 2007 2:23 am |
|
I have the same problem and thanks to helidoc's post...i got it fixed now. I changed and removed center tags from the following tpl files.
overall_header.tpl
overall_footer.tpl
index_body.tpl
viewtopic_body.tpl
again, thanks guys! |
|
|
|
 |
giantmidget
Regular


Joined: Nov 27, 2005
Posts: 58
|
Posted:
Sun Jul 29, 2007 1:04 pm |
|
See my responses in the IE centering sticky. I fixed SubBlack3d with two simple changes. |
|
|
|
 |
|