ShortLinks changes email addresses too !?

registered · Worker Joined: May 15, 2004 Posts: 119 Location: Germany

Hi,

if I activate ShortLinks by setting $tnsl_bUseShortLinks=TRUE, it works as it should!
The problem I have is that in some modules email addresses are rewritten to something like: beit&#..... instead of the real 'readable' address?

How can I stop that? I want to see email addresses in some of my modules like lazarusgb and others.

BTW, ShortenLinks did not work for modul Feedback?

registered · Posted: Sun Mar 18, 2007 10:08 am

Benson, I have never seen this happen to email addresses. I'll have to look into that more when I get back into town.

Regarding the Feedback module, there really is no value to shortening any links within there. However, the overall module (from the modules block) should be showing feedback.html right?

Posted: Sun Mar 18, 2007 11:31 am

montego wrote:

Benson, I have never seen this happen to email addresses. I'll have to look into that more when I get back into town.

Thanks a lot. Since email addresses are normally not shown as plain text, it might not be recognized by someone else. But in my module I need to show the email address as it is. Therefore the module prints it using a 'hex escape format' ... That is e.g. done by smarty library (http://smarty.php.net) to escape emails that they can not be found by robots etc.
Without ShortLinks active these escaped emails looks as normal text in my browser. If I turn it on, they are shown as 'hex encrypted'. So the problem is that these encrypted/escaped strings are not longer shown as normal text in the browser.

Quote:

Regarding the Feedback module, there really is no value to shortening any links within there. However, the overall module (from the modules block) should be showing feedback.html right?

Right, it shows the shorted address, but it ends up in a Error 404 ...
I added it to GTZ-PageTap.php and now it works ... Hmmm, maybe I did something wrong ... Don't worry about that ....

Posted: Wed Mar 21, 2007 7:09 am

Quote:

Right, it shows the shorted address, but it ends up in a Error 404

The 404 error is saying that it could not find the link, which is almost always an issue with the .htaccess file. I suspect that if you took whatever you added to GTZ-PageTap.php, it would work? If not, give me the complete link that is causing the 404 error.

BTW, on the email address thing, I also struggle with so little time on my hands. Can you help me by passing to me the complete module code and a dump of the tables being used by that module, zip it up, and send it to montego {{aT__ montegoscripts _$dot@@ com? (You see, we need that code in the forums here... lol).

Posted: Wed Mar 28, 2007 7:25 am

montego wrote:

BTW, on the email address thing, I also struggle with so little time on my hands. Can you help me by passing to me the complete module code and a dump of the tables being used by that module, zip it up, and send it to montego {{aT__ montegoscripts _$dot@@ com? (You see, we need that code in the forums here... lol).

Benson, do have something fairly easy for me to install and test with?

Posted: Tue Apr 03, 2007 6:35 am

benson, ok, haven't heard back from you...

How about this instead: please post back here just one example of what the raw email address (by viewing source) looks like with ShortLinks "OFF" (FALSE) and then again with ShortLinks "ON" (TRUE).

I need to see the before and after affects and it MUST be what you see by viewing source, NOT, what you see on the browser.

Thank you sir!

Posted: Fri May 11, 2007 7:17 am

benson, are you still out there?????

Posted: Thu May 24, 2007 7:11 am

Hi Montego,

yes, I am still alive Smile

. I had a lot of work the last weeks/months and by the way I got married yesterday ...

I just had no time to answer and I have to say, I missed it ...

Ok, my (I am the only one?) problem still exists. I found out that a new update version of RavenNuke came out...
I will try to update my homepage this week to the new version and than I activate the shotlinks to show you what problem I have. Ok ?

Code:

<td colspan="2" style="font-family:Verdana, Arial, Helvetica, sans-serif;font-size:11px;color:#000000;">b&amp;#x65;&amp;#x6e;son@&amp;#x67;mx.ne&amp;#x74;</td>

That piece of code is part of the guest book module 'lazarusgb' I use and it results in: benson@gmx.net instead of benson@gmx.net!

Code:

<td colspan="2" style="font-family:Verdana, Arial, Helvetica, sans-serif;font-size:11px;color:#000000;">benson@gmx.&#x6e;e&#x74;</td>

That is the code sent to the browser if ShortLinks is turned off.

I will now update my pages and come back to you. Than I will give you more details about the code that produces this html output.

Other mail addresses are generated as html output by smarty (see previous post).

And again, many thanks for your support and sorry that I did not reply earlier!!

Posted: Fri May 25, 2007 6:22 am

benson, congratulations on the marriage! Here is wishing you a life-time of wondering blessings and challenges (which if handled right will only make your love for each other stronger).

I know what is causing this, but I had put it on the back-burner. I am about to leave on a vacation with the wife so won't get back to reading this for quite awhile, but try this within your GTZ-PageTap.php file:

Add to the urlin array:

'&#'

Add to the corresponding urlout array element this:

'&#'

See if that works, but test many, many, many of your links to make sure it does not hose up anything else!

Although not tested either, here is another approach that I would also like you to try and if it works, I'll work it into ShortLinks's next version:

=== OPEN ===

includes/tegonuke/shortlinks/shortlinks.php

=== FIND AT BOTTOM ===

$getNextGen = str_replace(array('&&', '&middot;', '&nbsp;', ), array('&&', '·', ' '), $getNextGen);

=== REPLACE WITH ===

$getNextGen = str_replace(array('&&', '&middot;', '&nbsp;', '&#'), array('&&', '·', ' ', '&#'), $getNextGen);

=== DONE ===

But, again, this is going to take a ton of testing as this is only a "theory" at this point and I don't want it to impact any of the other rewriting that is being done. Hence why I had put this on the back-burner due to your lack of response... it was going to take alot of testing time. But, if you wouldn't mind helping to test this out thoroughly, this could be the route to go.

Posted: Sun Jun 03, 2007 4:19 am

Hi,
just a quick reply (ok, I know, again very late, but I am married now:-) ...)

The trick in the GTZ-PageTap.php file works! Now the Email URL s are shown they should!

I am still testing ...

Posted: Sun Jun 03, 2007 6:49 am

Excellent news, we'll keep our fingers crossed and hopefully it hasn't caused any other problems. Very Happy

Posted: Sun Jun 03, 2007 7:20 am

It still seams to work, on my local installation and on the web server (this trick should be mentioned to all who use modules with smarty library support or lazarusgb as guest book module!).

Now the hard work starts to add own modules to be translated too ... Shocked

Posted: Sun Jun 03, 2007 11:52 am

Hi,

I also had the same problem. Modifying GTZ-PageTap.php didn't work for me, it just gave a blank screen on accessing the site Sad

However, changing shortlinks.php did the job nicely, though I think I should point out that the two lines below are reversed!

The "FIND AT BOTTOM" line is the replacement code and the "REPLACE WITH" is the line you are looking for. At least that's what I did to make it work. I'll try and find faults but so far so good.

Thanks for the great work and support.

Cheers, Paul K

montego wrote:

benson, congratulations on the marriage! Here is wishing you a life-time of wondering blessings and challenges (which if handled right will only make your love for each other stronger).

I know what is causing this, but I had put it on the back-burner. I am about to leave on a vacation with the wife so won't get back to reading this for quite awhile, but try this within your GTZ-PageTap.php file:

Add to the urlin array:

'&#'

Add to the corresponding urlout array element this:

'&#'

See if that works, but test many, many, many of your links to make sure it does not hose up anything else!

Although not tested either, here is another approach that I would also like you to try and if it works, I'll work it into ShortLinks's next version:

=== OPEN ===

includes/tegonuke/shortlinks/shortlinks.php

=== FIND AT BOTTOM ===

$getNextGen = str_replace(array('&&', '&middot;', '&nbsp;', '&#'), array('&&', '·', ' ', '&#'), $getNextGen);

=== REPLACE WITH ===

$getNextGen = str_replace(array('&&', '&middot;', '&nbsp;', ), array('&&', '·', ' '), $getNextGen);

=== DONE ===

But, again, this is going to take a ton of testing as this is only a "theory" at this point and I don't want it to impact any of the other rewriting that is being done. Hence why I had put this on the back-burner due to your lack of response... it was going to take alot of testing time. But, if you wouldn't mind helping to test this out thoroughly, this could be the route to go.

Posted: Tue Jun 05, 2007 6:31 am

Paul_K, you are correct! So sorry folks! Embarassed

I have corrected my original post in order to avoid that confusion!

I will make the change to the shortlinks.php script for the next release of RN and ShortLinks. Thanks to all for your testing.

BTW, your edits of the GTZ file probably ended up leaving a comma in the wrong place in the array definition, which would cause the parse error (white page).