Php rendering issue in fisubice

Theme Guru Joined: Nov 01, 2003 Posts: 1006

Hi everyone,
I am having an issue that I've actually never come across before.

On a new ravennuke 2.10 site I have placed the fisubice theme that comes with the package.

I have changed the header.html to a header.php file that I know works correctly on another theme.

When I go into the fisubice theme.php and change the header.html to header.php this is what happens on the website.

Code:

\n"; echo "\n"; echo "\n"; echo "\n"; echo "\n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "   \n"; echo "  \n"; echo "  \n"; echo "  


\n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo " 


\n"; echo " 


\n"; echo " 


\n"; echo " 


\n"; echo "  \n"; echo "  \n"; echo "  


\n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  \n"; echo "  


\n"; echo " \n"; echo "\n"; echo "\n"; echo "\n"; ?>

If someone would be so kind as to explain to me why this is happening and how to correct it so that the php renders correctly, I would greatly appreciate it.
Confused

Posted: Mon Oct 29, 2007 8:23 am

I believe this is because the header.html is being eval'd after a lot of manipulations in theme.php to set it up correctly. Eval has the following definition from the PHP manual:

[quote]mixed eval ( string $code_str )

Evaluates the string given in code_str as PHP code. Among other things, this can be useful for storing code in a database text field for later execution

If you are trying to use a "normal" header.php file it's not going to work. Maybe you could quote here the contents of the file you are trying to substitute in. I never tried using a .php file with eval but I'm pretty sure you need to have it structured like the header.html file in the fisubice directory. I'm working towards eliminating the evals from the RN themes completely but it's a project that will take a couple of releases to complete.

Posted: Mon Oct 29, 2007 8:47 am

Here are the files that I have attempted to use.

There are two header.php files as neither will work. The first is the one that I actually want to use.

This is also the theme.php file that I actually want to use even though this exact problem happens with the theme.php file from the RN fisubice theme.

Please let me know that you have received them so that I can remove the link.

Posted: Mon Oct 29, 2007 9:07 am

Partially handled by PM. I have the files.

Just a general note: if you are trying to develop a new theme modeled on an existing theme (and LORDY, Jaded knows this better than I do) and if you are trying to use the eval method with separate html files for different areas (header, left, center, down) of the page then you really need to follow the model pretty explicitly and just change the layout elements. I believe that historically the eval method with separate html files was used in Nuke so that graphic designers could "slice up" their pages in say, Photoshop, and the programming could be separate from the design. As a programmer this gives me the heebie jeebies (a technical term). I'm trying to eliminate it eventually from Ravennuke. We can still keep design somewhat separate by using style sheets and we should be moving in that direction. But eval is inefficient and awkward and hard to maintain and I'd love to see it gone.

That said, I'm sure we can work this issue out.