NukeSentinel 2.5.18 and XHTML

Worker Joined: May 18, 2005 Posts: 119 Location: SVCDPlaza

I fond some XHTML issues in NukeSentinel
In admin\modules\nukesentinel\

funcions.php
Find

Code:




    echo '<tr><td>'.help_img(_AB_HELP_077).'</td><td><a href="'.$admin_file.'.php?op=ABIP2CountryMenu">'._AB_IP2COUNTRY.'</a></td>'."\n";


  } else {


    echo '<tr><td>'.help_img(_AB_HELP_078).'</td><td>'._AB_IP2COUNTRY.'</td>'."\n";

replace with

Code:




    echo '<tr><td>'.help_img(_AB_HELP_077).'</td><td><a href="'.$admin_file.'.php?op=ABIP2CountryMenu">'._AB_IP2COUNTRY.'</a></td></tr>'."\n";


  } else {


    echo '<tr><td>'.help_img(_AB_HELP_078).'</td><td>'._AB_IP2COUNTRY.'</td></tr>'."\n";

Find nowrap replace with nowrap="nowrap"
Find type=submit replace with type="submit"

ABAuthlist.php
Find nowrap replace with nowrap="nowrap"

ABBlockedIPList.php
Find nowrap replace with nowrap="nowrap"

ABBlockedRangeEditSave.php
Find nowrap replace with nowrap="nowrap"

ABBlockedRangeList.php
Find nowrap replace with nowrap="nowrap"

ABBlockedRangeOverlapCheck.php
Find nowrap replace with nowrap="nowrap"

ABCountryList.php
Find nowrap replace with nowrap="nowrap"

ABExcludedAddSave.php
Find nowrap replace with nowrap="nowrap"

ABExcludedEditSave.php
Find nowrap replace with nowrap="nowrap"

ABExcludedList.php
Find nowrap replace with nowrap="nowrap"

ABExcludedOverlapCheck.php
Find nowrap replace with nowrap="nowrap"

ABIP2CountryAddSave.php
Find nowrap replace with nowrap="nowrap"

ABIP2CountryEditSave.php
Find nowrap replace with nowrap="nowrap"

ABIP2CountryList.php
Find nowrap replace with nowrap="nowrap"

ABIP2CountryOverlapCheck.php
Find nowrap replace with nowrap="nowrap"

ABProtectedAddSave.php
Find nowrap replace with nowrap="nowrap"

ABProtectedEditSave.php
Find nowrap replace with nowrap="nowrap"

ABProtectedList.php
Find nowrap replace with nowrap="nowrap"

ABProtectedOverlapCheck.php
Find nowrap replace with nowrap="nowrap"

ABSearchIPResults.php
Find nowrap replace with nowrap="nowrap"

ABSearchRangeResults.php
Find nowrap replace with nowrap="nowrap"

ABTrackedAgentsIPs.php
Find nowrap replace with nowrap="nowrap"

ABTrackedAgentsList.php
Find nowrap replace with nowrap="nowrap"

ABTrackedList.php
Find nowrap replace with nowrap="nowrap"

ABTrackedPages.php
Find nowrap replace with nowrap="nowrap"

ABTrackedRefersIPs.php
Find nowrap replace with nowrap="nowrap"

ABTrackedRefersList.php
Find nowrap replace with nowrap="nowrap"

ABTrackedUsersIPs.php
Find nowrap replace with nowrap="nowrap"

ABTrackedUsersList.php
Find nowrap replace with nowrap="nowrap"

ABMain.php
Find type=submit replace with type="submit"

ABBlockedIPAdd.php
Find type=submit replace with type="submit"

ABBlockedIPList.php
Find selected=\"selected\" replace with selected="selected"

ABBlockedIPEdit.php
Find type=submit replace with type="submit"

ABBlockedRangeList.php
Find selected=\"selected\" replace with selected="selected"

ABBlockedRangeEdit.php
Find type=submit replace with type="submit"

ABExcludedAdd.php
Find type=submit replace with type="submit"

ABConfig.php
Find type=submit replace with type="submit"

ABConfigAdmin.php
Find type=submit replace with type="submit"

ABConfigAuthor.php
Find type=submit replace with type="submit"

ABConfigClike.php
Find type=submit replace with type="submit"

ABConfigFilter.php
Find type=submit replace with type="submit"

ABConfigFlood.php
Find type=submit replace with type="submit"

ABConfigHarvester.php
Find type=submit replace with type="submit"

ABConfigReferer.php
Find type=submit replace with type="submit"

ABConfigRequest.php
Find type=submit replace with type="submit"

ABConfigScript.php
Find type=submit replace with type="submit"

ABConfigString.php
Find type=submit replace with type="submit"

ABConfigUnion.php
Find type=submit replace with type="submit"

ABAuthEdit.php
Find type=submit replace with type="submit"

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Thanks!

Posted: Fri Jun 06, 2008 2:56 pm

modules\NukeSentinel

functions.php
Find

Code:




echo '<td align="center" width="34%" nowrap>'."\n";

replace with

Code:




echo '<td align="center" width="34%" nowrap="nowrap">'."\n";

registered · Posted: Fri Jun 06, 2008 10:49 pm

I figured there would be some that I missed. So many files that the ole eyes didn't see the type=submit . Didn't find a reference on wheither it was nowrap or nowrap="nowrap" not to mention tidy didn't catch either of those either Sad

Posted: Fri Jun 06, 2008 10:59 pm

Just as an fyi, all single properties must be property="property"

Posted: Sat Jun 07, 2008 12:32 am

In admin\modules\nukesentinel\

funcions.php
Find

Code:




  echo '<select name="importer" size="15" onChange="submit()">'."\n";

replace with

Code:




  echo '<select name="importer" size="15" onchange="submit()">'."\n";

xhtml requires all lower-case for attribute names.

ABTrackedAgentsPages.php & ABTrackedRefersPages.php & ABTrackedUsersPages.php
Find

Code:




  echo '<td bgcolor="'.$bgcolor2.'" width="20%"><strong>'._AB_DATE.'</strong></td>'."\n";

replace with

Code:




  echo '<td bgcolor="'.$bgcolor2.'" width="20%"><strong>'._AB_DATE.'</strong></td></tr>'."\n";

It looks to me that it is now 100% xhtml
Bob if you want the file's just let me now and i sent them to you.

Posted: Sat Jun 07, 2008 8:10 am

I've caught a few more </tr>'s then those along with those. It is interesting just what tidy has missed. Goes to show no matter what tool you use it rarely catches it all.

Posted: Sat Jun 07, 2008 8:23 am

I use Mozilla Firefox 3.0 RC2 and HTML Validator 0.8.4.6 add-on and thats working very good.

Posted: Sat Jun 07, 2008 11:35 am

kenwood wrote:

I use Mozilla Firefox 3.0 RC2 and HTML Validator 0.8.4.6 add-on and thats working very good.

That's the best (x)html validator firefox addon i have ever found... works just great