functions for including files

Involved Joined: Apr 06, 2008 Posts: 484

Ive been thinking about this today.Is my train of thought on the right track here.

if we used functions for checking if a file exists, in a basic ravennuke installation this could cut out as much as 600 lines of code

Code:




function _include_once($file) {


   if (file_exists($file)) {


      include_once($file);


   }


}


 


function _require_once($file) {


   if (file_exists($file)) {


      require_once($file);


   }


}

Posted: Wed Nov 18, 2009 5:11 am

include() and require() are already native PHP functions but I see what your driving at.

Posted: Wed Nov 18, 2009 6:33 am

I get what you are talking about, but since it is doing the exact same thing. The difference in not loaded a few lines of text server side is really insignificant.

Posted: Wed Nov 18, 2009 4:04 pm

ok, thanks, that makes sense.

registered · Posted: Fri Nov 20, 2009 1:20 am

include and include_once aren't necessarily the same thing. Granted phpNuke generally only needs include_once, rarely should be including a file twice.

http://us3.php.net/manual/en/function.include.php
Require emits a fatal error, in that respect a file_exists check is nice to have.