Author |
Message |
hicuxunicorniobestbuildpc
The Mouse Is Extension Of Arm
![](modules/Forums/images/avatars/5ed231554a8492e2e09da.gif)
Joined: Aug 13, 2009
Posts: 1123
|
Posted:
Sat Aug 11, 2012 10:00 am |
|
Hi Guys, I wonder if anyone can help me to solve a validation error I have on this mod.
Code: OpenTable();
//tags cloud by unicornio
function otoTag($tag,$link,$en_tagi=10,$en_tago=18) {
$renk='#'.dechex(rand(1,16)).dechex(rand(1,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16));
$boy=rand($en_tagi,$en_tago);
echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>';
}
$target=$db->sql_query("SELECT lid,title FROM ".$prefix."_nsngd_downloads ORDER BY rand() limit 50");
while ($sonic=$db->sql_fetchrow($target))
{
echo otoTag($sonic[title],'modules.php?name=Downloads&d_op=getit&lid='.$sonic[lid]);
}
//tags cloud
CloseTable();
|
error I am getting is from this part.
Code:echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>'
|
The mod works perfect but I just need a little help to know where I can validate this part above. This is the warning.
Warning: <a> proprietary attribute "tag"
The tag contains an attribute that is proprietary to Netscape or Internet Explorer.
In my eyes I don't see any problem... |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
neralex
Site Admin
![](modules/Forums/images/avatars/201442295664a46e4575d46.jpg)
Joined: Aug 22, 2007
Posts: 1775
|
Posted:
Sat Aug 11, 2012 10:37 am |
|
quick & shortly: "tag" is not an attribute of the a tag! perhaps you mean title?! |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
hicuxunicorniobestbuildpc
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Aug 11, 2012 10:48 am |
|
Neralex, thanks for pushing me to the right direction! ![Very Happy](modules/Forums/images/smiles/icon_biggrin.gif) |
Last edited by hicuxunicorniobestbuildpc on Sat Aug 11, 2012 11:44 am; edited 1 time in total |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
neralex
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Aug 11, 2012 10:50 am |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
hicuxunicorniobestbuildpc
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Aug 11, 2012 11:01 am |
|
This is what I did so far
Code:echo '<a id="" href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'"
tag="' . $tag . '">' . $tag . ' </a>';
}
|
but I get the same error ![Shocked](modules/Forums/images/smiles/icon_eek.gif) |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
nuken
RavenNuke(tm) Development Team
![](modules/Forums/images/avatars/3234de284ee21bd39eecd.jpg)
Joined: Mar 11, 2007
Posts: 2024
Location: North Carolina
|
Posted:
Sat Aug 11, 2012 11:12 am |
|
Your link to the download is wrong too. should be op and not d_op. |
_________________ Only registered users can see links on this board! Get registered or login! |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
hicuxunicorniobestbuildpc
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Aug 11, 2012 11:34 am |
|
Finally I fix it. I was so easy. thanks guy. I do know u want me to learn but sometimes u are a little bit too hard. Let me know if it is correct.
Code:echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'">' . $tag . ' </a>';
}
|
Now it is validated
I didn't want to share the whole mode until I get it validated.
Here we go! This is a very easy mod and beautiful tags cloud.
Open your ftp
modules/Downloads/public/index.php
Open index.php
Search for at the botton
Code:CloseTable();
include_once 'footer.php';
|
Replace with
Code:CloseTable();
OpenTable();
//tags cloud by unicornio
function otoTag($tag,$link,$en_tagi=10,$en_tago=18) {
$renk='#'.dechex(rand(1,16)).dechex(rand(1,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16)).dechex(rand(0,16));
$boy=rand($en_tagi,$en_tago);
echo '<a href="'.$link.'"
style="font-size: ' . $boy . 'px;color:'.$renk.'">' . $tag . ' </a>';
}
$target=$db->sql_query("SELECT lid,title FROM ".$prefix."_nsngd_downloads ORDER BY rand() limit 50");
while ($sonic=$db->sql_fetchrow($target))
{
echo otoTag($sonic[title],'modules.php?name=Downloads&op=getit&lid='.$sonic[lid]);
}
//tags cloud
CloseTable();
include_once 'footer.php';
|
Note: This mod is for RavenNuke 2.50 Download module from Montego. If you have any other download module could be easy too.
If you think you can make it better, please share it with us. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
neralex
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sun Aug 12, 2012 3:36 pm |
|
I think a tag cloud is not needed for the download module but this only my opinion. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
hicuxunicorniobestbuildpc
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sun Aug 12, 2012 4:57 pm |
|
neralex, I think tag cloud for the download module is pretty good. We have tag cloud for the news too. Image you have 200 topics and with tag cloud you can find what u forgot or what u didn't see yourself. It is like the supermarket. Everyday they change articles so the next time you will find another product and so on. It is marketing and beautiful. It is just my opinion, maybe you are right. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
neralex
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Mon Aug 13, 2012 5:37 am |
|
Articles and downloads are two completely different content types. One has nothing to do with the other. Tags of different content types in the same cloud makes no sense for me. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
Susann
Moderator
![](modules/Forums/images/avatars/4e3210db4efb891870d79.gif)
Joined: Dec 19, 2004
Posts: 3191
Location: Germany:Moderator German NukeSentinel Support
|
Posted:
Mon Aug 13, 2012 4:35 pm |
|
Quote: | It is marketing and beautiful |
No, you have to be very carefully by using tagclouds and keyword stuffing in this way from Seo point of view.
Maybe rel="nofollow" will help but I would not use a tagcloud in my downloadsection because its not needed. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
kguske
Site Admin
![](modules/Forums/images/avatars/41f0b40a419280935f3a0.gif)
Joined: Jun 04, 2004
Posts: 6437
|
Posted:
Tue Aug 21, 2012 8:32 am |
|
Susann, definitely agree that tag clouds should be used carefully, if at all. What are your thoughts on using tag clouds on multilingual sites? |
_________________ I search, therefore I exist...
Only registered users can see links on this board! Get registered or login! |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
Susann
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Tue Aug 21, 2012 10:02 am |
|
Sounds like a very interesting feature since all sites have normally worldwide traffic but the rules are more or less the same. In any event it should be used very carefully.
Beside this the hype with tag clouds is since a long time over I believe.
And if Google doesn´t like your site anymore you will have a hard time to get back the previous status. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
kguske
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Tue Aug 21, 2012 10:29 am |
|
I agree and definitely appreciate your input on these subjects as your international perspective is very valuable.
IMO, the "wow" factor of tag clouds is short lived, probably because they don't really help visitors and because the SEO benefits are questionable. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
|