Author |
Message |
dalantos
New Member
Joined: Jul 18, 2010
Posts: 11
|
Posted:
Wed Sep 05, 2012 9:42 pm |
|
Hello everyone,
When I apply a custom theme to my new site built on ravennuke 2.5, the new user registration page seems to behave strangely. When I apply any of the out of the box themes these problems do not exist.
IE 9: when I enter bad information or leave out information it will provide a warning the first time and then will not report wrong information clearly on subsequent bad tries.
When I provide proper information the "continue" button does not trigger any event. With bad data on the first try though, it will only trigger an event when I do not provide a proper username. Once a valid user name is entered, the continue button does nothing. Even if it is changed to an invalid one afterward.
Also the first password block seems to prefill itself with something after a failed attempt(it is masked).
Firefox: Most of the issues seem to work fine, but the continue button still does not work. It just does nothing when I have good information entered.
Site: [ Only registered users can see links on this board! Get registered or login! ]
So my question is whether any of you RavenNuke masters have a clue what we messed up in our theme to break this functionality?
A final note is that this theme was originally made to be compatible with RavenNuke 2.4.
Thank you in advance. |
|
|
|
|
nuken
RavenNuke(tm) Development Team
Joined: Mar 11, 2007
Posts: 2024
Location: North Carolina
|
Posted:
Wed Sep 05, 2012 10:27 pm |
|
Your theme has a lot of validation errors. My guess would be your problem is some where in there.
[ Only registered users can see links on this board! Get registered or login! ] |
_________________ Tricked Out News |
|
|
|
dalantos
|
Posted:
Wed Sep 05, 2012 11:55 pm |
|
thanks for the response, I am working the errors, any chance you could be more specific to the issue though? eg any chance you could offer some speculation on what would actually cause this feature to break specifically? Understand that I have used an outside designer to develope the theme and am now scrambling to resolve the issues with it so the site can launch. Like an idiot I did not do a w3c validation check before approving the theme. Most of these errors proving difficult for me to discern where they are coming from so I am combing through the scripts comparing them to the fiscube and applying best practices that I know of to try and clean it up in the hopes that I will stumble over the reason why the continue button will not work.
So any help in getting me closer would sure save some time and effort while I attempt to fix this. |
|
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 12:34 am |
|
nevermind, I want to thank you for the information you did give, it reminded me to go back to the basics and never assume. Anyhow there was a section for javascript that was a placeholder and unused and apparently was messing with the whole theme.
This code was breaking it.
/************************************************************/
/* Javascripts Area */
/* */
/************************************************************/
echo " <SCRIPT language=JavaScript> \n";
echo " function Art(img_name,url) { \n";
echo " document[img_name].src=url; \n";
echo " } \n";
echo " </SCRIPT> \n";
Thanks again for your help. |
|
|
|
|
hicuxunicorniobestbuildpc
The Mouse Is Extension Of Arm
Joined: Aug 13, 2009
Posts: 1123
|
Posted:
Thu Sep 06, 2012 1:46 am |
|
dalantos. Why did you remove copyright? Strange nuken didn't notice. |
|
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 1:49 am |
|
hrm, well I personally didn't, the guy who built the theme did. Which one am I missing? |
|
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 2:08 am |
|
sorry man you are going to have to educate me here, I am not finding any of the copyrites missing. I know I have not modified any of the code to remove any of that. Any chance you can be more specific about which one is missing, or perhaps where it might have been plucked from? This is a standard install of RavenNuke with a custom theme applied so short of adding in extra lines into the footer I am not sure what else should be done. Either way I doubt any copyright was intentionally remove by me or the theme designer. |
|
|
|
|
hicuxunicorniobestbuildpc
|
Posted:
Thu Sep 06, 2012 2:18 am |
|
Code:go you yoursite.com/admin.php
Click on Preferences
<p>
You can syndicate our news using the file <a href="backend.php" target="_blank"><span class="footmsg_l">backend.php</span></a>.<br />
<span class="footmsg_l"><a href="http://www.ravenphpscripts.com" target="_blank" title="Code written and maintained by RavenNuke TEAM">Code written and maintained by RavenNuke™ TEAM</a></span></p>
|
This has nothing to do with your theme |
|
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 2:24 am |
|
Good to go thanks! Its been inserted. |
|
|
|
|
hicuxunicorniobestbuildpc
|
Posted:
Thu Sep 06, 2012 2:35 am |
|
Ok, since you have 205 warning then follow this examples
BAD
Code:<img src="themes/Mason/images/space.gif" width="5" height="27">
|
Good
Code:<img src="themes/Mason/images/space.gif" alt="" width="5" height="27" />
|
you can also zip your theme and send it to me and I will try to correct all the warnings to make it validated. Thanks for making the modification to bring the copyright back. |
|
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 2:39 am |
|
Of course, and thanks for the offer, but I believe I have a handle on it now. Sometimes a little tough love to get us doing it right is the way to go. I am squashing the errors, and have brought the number down to about 400 or so thus far. I'll keep working them until they are good to go. |
|
|
|
|
hicuxunicorniobestbuildpc
|
Posted:
Thu Sep 06, 2012 2:41 am |
|
The best is to do it yourself in order to learn.
Code:BAD <table height="100%">
Good <table style="height: 100%">
|
Code:BAD
<td><IMG SRC="themes/Mason/images/block01a.jpg"></td>
GOOD
<td><img src="themes/Mason/images/block01a.jpg" alt="" /></td>
|
|
Last edited by hicuxunicorniobestbuildpc on Thu Sep 06, 2012 2:44 am; edited 1 time in total |
|
|
|
dalantos
|
Posted:
Thu Sep 06, 2012 2:44 am |
|
yea, thats the theme designer, most of this code looks like that. Hence he will be getting a call tomorrow. He is uh...old school html trained but a artistic. I suck at art. |
|
|
|
|
neralex
Site Admin
Joined: Aug 22, 2007
Posts: 1774
|
Posted:
Thu Sep 06, 2012 6:52 am |
|
unicornio wrote: | Code:BAD <table height="100%">
Good <table style="height: 100%">
| |
This is not bad. The table tag can be used with width and height as own attribute. You can use the styles with the td-tag!
for example and you get no validation-errors:
Code:<table height="100%">
<tr>
<td style="height: 100%"></td>
</tr>
</table>
|
|
|
|
|
|
hicuxunicorniobestbuildpc
|
Posted:
Thu Sep 06, 2012 4:10 pm |
|
Thanks neralex, Is this another way to do it? |
|
|
|
|
neralex
|
Posted:
Thu Sep 06, 2012 4:37 pm |
|
I mean, its not wrong if you use the attributes "width" and "height" with the table tag. |
|
|
|
|
nuken
|
Posted:
Sat Sep 08, 2012 8:10 am |
|
If you still need help, dalantos, I will be glad to take a look. I am busy this weekend, but should have some extra time the early part of this coming week. |
|
|
|
|
|