Fix Cosmetic in Sand_Journey theme

Worker Joined: Jul 20, 2004 Posts: 189 Location: Italy

In style.css, the following code, for title style in News,

Code:

.title {background: none; color: #000000; font-size: 14px; font-weight: bold; font-family: Verdana, Helvetica; text-decoration: none}

is also used for style in the text:

Code:

define('_NOCOMMENTSACT','Sorry, Comments are not available for this article.');

.

I think it is necessary to change 14px with 10px and no bold.

What to do?

registered · Site Admin Joined: Aug 22, 2007 Posts: 1775

For both together you can change the styles of the css-class:

Code:

.title {background: none; color: #000000; font-size: 10px; font-weight: normal; font-family: Verdana, Helvetica; text-decoration: none}

BTW: While checking this theme i have found some little bugs in the theme.php, they destroy the validation. I have it fixed.

function themeheader:

find:

Code:

$topics_list .= '<option ' . $sel . ' value="' . $topicid . '">' . $topics . '</option>' . "\n";

change to:

Code:

$topics_list .= '<option ' . $sel . ' value="' . $topicid . '">' . htmlspecialchars($topics, ENT_QUOTES, _CHARSET) . '</option>' . "\n";

function themearticle:

find:

Code:

<td bgcolor="' , $bgcolor1 , '"">

change to:

Code:

<td bgcolor="' , $bgcolor1 , '">

find:

Code:

<a href=modules.php?name=News&amp;new_topic=' , $topic , '>

change to:

Code:

<a href="modules.php?name=News&amp;new_topic=' , $topic , '">

Posted: Tue Apr 16, 2013 4:51 am

Many thanks for your help.

neralex wrote:

For both together you can change the styles of the css-class:

Code:

.title {background: none; color: #000000; font-size: 10px; font-weight: normal; font-family: Verdana, Helvetica; text-decoration: none}

For the first fix: I must have the text title of the news with 14px and the text of

Sorry, Comments are not available for this article.

Code:

define('_NOCOMMENTSACT','Sorry, Comments are not available for this article.');

with 10 px.

Posted: Tue Apr 16, 2013 5:14 pm

Create a new css-class inside your style.css of your theme like this:

Code:

.mynewstitle {background: none; color: #000000; font-size: 14px; font-weight: normal; font-family: Verdana, Helvetica; text-decoration: none}

Open your theme.php and replace:

Code:

<span class="title">' , $title , '</span>

with

Code:

<span class="mynewstitle">' , $title , '</span>

Its only needed to change the css-class to the new one. Play with the attributes of the class. On this way you can create your own theme. Smile

registered · Site Admin Joined: Jun 04, 2004 Posts: 6437

Well done, neralex!

Posted: Thu Apr 18, 2013 9:28 am

I made the changes but the text (Sorry, Comments are not available for this article.) remained 14px.
In theme.php, when I change only the line 153, nothing happens; but when I change lines 153, 181 and 190 only the title of the news becomes 10px.
I need 10px only in:

Code:

define('_NOCOMMENTSACT','Sorry, Comments are not available for this article.');

Posted: Thu Apr 18, 2013 10:00 am

Eduardo, use please the css-classes inside your styles.css of your theme and change the classes in your theme.php. I have give you two examples. Play with it, this is best way to learn the basics of css.

http://www.w3schools.com/css/
https://getfirebug.com/

Posted: Thu Apr 18, 2013 1:33 pm

Many thanks for your valuable suggestions.

Posted: Thu Apr 18, 2013 1:53 pm

Copy & paste is easy but the understanding of it is more valuable. Smile

Posted: Fri Apr 19, 2013 1:15 pm

Neralex

I'm sorry, my small contribution can only to identify inconsistencies graphics.
If you appreciate the Raven work can help him correcting them.
You can begin to correct the size text errors in the following themes:

Blue_Blog: correct
CT_RN: correct
fisubice: incorrect in "Read more..."
RavenIce: correct
RickTido: correct in home incorrect in "Read more..."
Sand_Journey: incorrect in home incorrect in "Read more..."
SimplyBlue: correct

Posted: Fri Apr 19, 2013 1:45 pm

Its all open source stuff. Sou you can try to fix it self. Why i should fix all themes? After you comes the next one with a new list, because he means it must bigger or smaller and then i should change it again...?

Posted: Sat Apr 20, 2013 12:33 am

My report concerns a real inconsistency is not a customization.
The portion of the text that I have shown is truly unbalanced.
So it's not my own personal aesthetic requirements.
You do not have any obligation.
My reporting will surely be appreciated by Raven staff.
I am sure that the next version of the script will contain the necessary improvements.

Posted: Sat Apr 20, 2013 4:03 am

Inconsistency of css styles? Then you must wait and hope.

Posted: Sat Apr 20, 2013 4:14 am

The news title is more important than a comment.
Then the text size must be adequate.

registered · Posted: Sat Apr 20, 2013 7:01 am

The sizes of the text in the themes are all based on personal preference. It you wish to change the size, either modify the the css style for it or assign one if there is no style already assigned to it. CSS styles are easy to understand and change.

Posted: Sun Apr 21, 2013 3:02 am

Nuken
You are the author of the theme RickTido.
Please analyze this inconsistency in the size of the text and tell me if it is true.

In home page:

In News, Read More

I think that in Read More the text must have the same size.

Posted: Sun Apr 21, 2013 7:06 am

Again, that is a personal preference. I like the smaller title on the articles page since the person has already clicked on the title or the read more link and is now wanting to read the content. If you want to change it, just modify the class in the themearticle function of the theme.php.

Code:




<h1 class="title">'.$title.'</h1>

to

Code:




<div class="newstitle">'.$title.'</div>

Or create your own css class to make the text look like you want it to.