| Author |
Message |
ring_c
Involved
Joined: Dec 28, 2003
Posts: 276
Location: Israel
|
 Posted:
Sun Nov 27, 2005 12:01 am |
|
First, Rave, you've done a greate job, as usual! Thanks!!!
Trying to implement it in my site, I got some suggestions from fellow admins:
1. Having the option to disable the rotating line.
2. Showing more than 1 last message when block is closed.
3. Changing the "show/hide" text to something more interactive. Maybe a small gfx that will change on mouse hover? It seems that even expert users do not understand this button can do something...
4. Showing last posted message according to the date/time the first message was sent, and not upon the last comment date/time.
Would appreciate to know if these could be somehow implemented...
TIA and keep the good work! |
| |
|
 
|
|
Raven
Site Admin/Owner
Joined: Aug 27, 2002
Posts: 17088
|
| Posted:
Sun Nov 27, 2005 12:39 am |
|
Good suggestions. I will add these to my "to do" list 
#4 doesn't feel right to me or I'm not understanding it. Why would you not want to know the last post date? |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 1:40 am |
|
Thanks, Raven. I'll be a bit pushy and ask when do you think it could be implemented?
Re #4 - let's assume you have a news site, and you want to show the news according to their date/time accurance regardless of the replies' date/time. You'll want to show the posts according to the first post's date/time of creation. |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 1:49 am |
|
| ring_c wrote: | | Thanks, Raven. I'll be a bit pushy and ask when do you think it could be implemented? |
No ETA. If you'd like me to prioritize it, then you can contract with me. |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 8:29 am |
|
Also, there seem to be a bug in the last public version (2.2.0). If I have this line:
$showJumpBox = FALSE;
I still see on jump box, while the other is gone.
Any fix avail. ? |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 8:42 am |
|
| ring_c wrote: | Also, there seem to be a bug in the last public version (2.2.0). If I have this line:
$showJumpBox = FALSE;
I still see on jump box, while the other is gone.
Any fix avail. ? |
The one remaining is NOT the forum jump box. It's the FUNCTION jump box. |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 8:49 am |
|
| Quote: |
The one remaining is NOT the forum jump box. It's the FUNCTION jump box.
|
And there's no "header" way to hide it? |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 9:03 am |
|
I never said that. I'll be releasing a new version soon. It will be fixed. ITMT, you can do this.
Edit blocks/block-ForumsCollapsing.php
- Using an editor of your choice, change all occurences of $showJumpBox to $showJumpBoxes.
- Then find
Code:$content .= <<<_JS_
<center><table align="center" width="100%"><tr><td align="center" ><b>$bfcJumpFunction</b></td><td align="center"><b>$bfcJumpForum</b></td></tr>
<tr><td align="center">$links</td><td align="center">$boxstring</td></tr>
</table>
<br />
<table><tr><th height="25" align="center" nowrap width="49%"><font color="$textcolor1"><strong><i>[$bfcForum]</i> $bfcTopic</strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcReplies </strong></font></th><th width="17%" align="center" nowrap><font color="$textcolor1"><strong> $bfcAuthor </strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcViews </strong></font></th><th align="center" nowrap><font color="$textcolor1"><strong> $bfcLastPost </strong></font></th></tr></table></center>
_JS_;
|
And change it to
Code:
if ($showJumpBoxes) $content .= <<<_JS_
<center><table align="center" width="100%"><tr><td align="center" ><b>$bfcJumpFunction</b></td><td align="center"><b>$bfcJumpForum</b></td></tr>
<tr><td align="center">$links</td><td align="center">$boxstring</td></tr>
</table>
<br />
_JS_;
$content .= <<<_JS_
<table><tr><th height="25" align="center" nowrap width="49%"><font color="$textcolor1"><strong><i>[$bfcForum]</i> $bfcTopic</strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcReplies </strong></font></th><th width="17%" align="center" nowrap><font color="$textcolor1"><strong> $bfcAuthor </strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcViews </strong></font></th><th align="center" nowrap><font color="$textcolor1"><strong> $bfcLastPost </strong></font></th></tr></table></center>
_JS_;
|
|
Last edited by Raven on Mon Nov 28, 2005 10:05 am; edited 1 time in total |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 9:23 am |
|
Thanks alot, Raven, but it doesn't seem to work 
I'm getting this error:
Code:Parse error: parse error, unexpected T_SL in /home/hagigim/public_html/blocks/block-ForumsCollapsing.php on line 246
|
|
Last edited by ring_c on Sun Nov 27, 2005 9:28 am; edited 1 time in total |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 9:26 am |
|
The line number 246 is:
if ($showJumpBoxes) $content .= <<<_JS_ |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 9:27 am |
|
It works here so it must have to do with the new release changes. I guess you'll just have to be patient a while longer  |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 9:29 am |
|
| Raven wrote: | | It works here so it must have to do with the new release changes. I guess you'll just have to be patient a while longer |
Ok, thanks. and I won't push my luck asking when you think it'll be due. |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 9:30 am |
|
Oh, that's different. That means that your closing _JS_; is NOT left justified. It must be on a separate line, left justified, and NO white space after it. It's a PHP syntactical requirement. |
Last edited by Raven on Sun Nov 27, 2005 9:47 am; edited 1 time in total |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 9:39 am |
|
| Raven wrote: | | Oh, that's different. That means that your closing _JS_; is NOT left justified. It must be on a separate line and left justified. It's a PHP syntactical requirement. |
Could you repeat it slowly and in plain English, please?
Anwyay, here's the section's code:
Code:if ($showJumpBoxes) $content .= <<<_JS_
<center><table align="center" width="100%"><tr><td align="center" ><b>$bfcJumpFunction</b></td><td align="center"><b>$bfcJumpForum</b></td></tr>
<tr><td align="center">$links</td><td align="center">$boxstring</td></tr>
</table>
<br />
_JS_;
$content .= <<<_JS_
<table><tr><th height="25" align="center" nowrap width="49%"><font color="$textcolor1"><strong><i>[$bfcForum]</i> $bfcTopic</strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcReplies </strong></font></th><th width="17%" align="center" nowrap><font color="$textcolor1"><strong> $bfcAuthor </strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcViews </strong></font></th><th align="center" nowrap><font color="$textcolor1"><strong> $bfcLastPost </strong></font></th></tr></table></center>
_JS_;
|
|
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 9:46 am |
|
See that last line _JS_; ? Make sure that it is left justified and that there is NO whitespace after it. |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 9:49 am |
|
It IS left justify, but there's a blank line between this line and the other. like this:
_JS_;
$result = $db->sql_query
Is that wrong too? |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 9:54 am |
|
No. But hidden characters often lurk after the closing ;. If there are none then you'll just have to wait, but I suspect there is something after the ;. |
| |
|
|
|
|
ring_c
|
| Posted:
Sun Nov 27, 2005 11:39 am |
|
No, there's nothing.
Here's EditPLUS' screen capture:
 |
| |
|
|
|
|
Raven
|
| Posted:
Sun Nov 27, 2005 3:00 pm |
|
Did you change $showJumpBox to $showJumpBoxes at the top? Also, remove the space after the _JS_ on the first line, just for good measure. |
| |
|
|
|
|
ring_c
|
| Posted:
Mon Nov 28, 2005 12:07 am |
|
| Quote: |
Did you change $showJumpBox to $showJumpBoxes at the top?
|
Yes, Sir.
| Quote: |
Also, remove the space after the _JS_ on the first line, just for good measure.
|
You're a magician, my friend!
Who would think this little space would create so much fuss?
Thanks ALOT!!!! |
| |
|
|
|
|
ring_c
|
| Posted:
Mon Nov 28, 2005 12:32 am |
|
Raven, I was trying to remove the underline from the usernames (poster and last comment sender) but couldn't find the relevant <u> and </u> tags.
Could you direct me somehow please? |
| |
|
|
|
|
ring_c
|
| Posted:
Mon Nov 28, 2005 3:40 am |
|
Dear Raven, I've just noticed that the change made the rubric's titles disappear.
Also, I love the new version you're using which removes completely the first rotating line. is there any chance to get it? |
| |
|
|
|
|
Raven
|
| Posted:
Mon Nov 28, 2005 9:23 am |
|
I have no idea what "rubric" is. |
| |
|
|
|
|
ring_c
|
| Posted:
Mon Nov 28, 2005 9:51 am |
|
This is how it looks like.
Please disregard the Hebrew characters. you would see there're no titles (forum name, poster, last comment date etc...)
 |
| |
|
|
|
|
Raven
|
| Posted:
Mon Nov 28, 2005 10:04 am |
|
Modify the code to read
Code:if ($showJumpBoxes) $content .= <<<_JS_
<center><table align="center" width="100%"><tr><td align="center" ><b>$bfcJumpFunction</b></td><td align="center"><b>$bfcJumpForum</b></td></tr>
<tr><td align="center">$links</td><td align="center">$boxstring</td></tr>
</table>
<br />
_JS_;
$content .= <<<_JS_
<table><tr><th height="25" align="center" nowrap width="49%"><font color="$textcolor1"><strong><i>[$bfcForum]</i> $bfcTopic</strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcReplies </strong></font></th><th width="17%" align="center" nowrap><font color="$textcolor1"><strong> $bfcAuthor </strong></font></th><th width="3%" align="center" nowrap><font color="$textcolor1"><strong> $bfcViews </strong></font></th><th align="center" nowrap><font color="$textcolor1"><strong> $bfcLastPost </strong></font></th></tr></table></center>
_JS_;
|
Make sure there ar no spaces after any of the _JS_ or _JS_;
I have corrected the code above also. |
| |
|
|
|
|
|
|
![[Valid RSS]](https://www.ravenphpscripts.com/images/valid-rss.png "Validate my RSS feed"){kind=small}
