Author |
Message |
kguske
Site Admin

Joined: Jun 04, 2004
Posts: 6437
|
Posted:
Mon Apr 21, 2008 7:54 pm |
|
One of the changes with FCKeditor 2.6 that will impact upgrades is that the directory names have changed to all lower case. This causes problems on operating systems that are case sensitive AND previously uploaded files to the includes/FCKeditor/uploads/Image, includes/FCKeditor/uploads/Flash, includes/FCKeditor/uploads/File, or includes/FCKeditor/uploads/Media directories, since these would now become: includes/fckeditor/uploads/image, includes/fckeditor/uploads/flash, includes/fckeditor/uploads/file, and includes/fckeditor/uploads/media respectively.
Since this impacts our ability to upgrade in the future, it makes sense to move the uploads out of this directory. I thought about putting it in the /images/ directory, but since there are more than just images, I didn't want to do that. My next choice was /resources/ and we spent several days testing this (it worked fine on Linux, but failed on Windows). Why? I first thought there might be an issue with _SERVER['PHP_SELF'], but finally figured out that Windows protects the directory name resources!
The question: what to name the folder? Some suggestions:
/files/
/res/
/uploads/
I'm leaning toward /res/ - short for resources, which is more descriptive than files, but wanted to get input before moving ahead. What would you prefer? |
_________________ I search, therefore I exist...
Only registered users can see links on this board! Get registered or login! |
|
|
 |
Gremmie
Former Moderator in Good Standing

Joined: Apr 06, 2006
Posts: 2415
Location: Iowa, USA
|
Posted:
Mon Apr 21, 2008 8:14 pm |
|
Does it upload more than images? How about /media? |
_________________ Only registered users can see links on this board! Get registered or login! - An Event Calendar for PHP-Nuke
Only registered users can see links on this board! Get registered or login! - A Google Maps Nuke Module |
|
|
 |
kguske

|
Posted:
Mon Apr 21, 2008 8:19 pm |
|
It will have the following subdirectories:
file
flash
image
media
The default in FCKeditor is /userfiles/ but that's a subdirectory / folder of fckeditor, which makes upgrading more difficult. |
|
|
|
 |
kguske

|
Posted:
Tue Apr 22, 2008 5:37 am |
|
How about a default, and the ability to override this by adding a variable in config.php / rnconfig.php ?
But the question remains, what should be the default?
/files/
/res/
/uploads/
? |
|
|
|
 |
jakec
Site Admin

Joined: Feb 06, 2006
Posts: 3048
Location: United Kingdom
|
Posted:
Tue Apr 22, 2008 5:59 am |
|
Personally I would choose uploads. JMO |
|
|
|
 |
montego
Site Admin

Joined: Aug 29, 2004
Posts: 9457
Location: Arizona
|
Posted:
Tue Apr 22, 2008 6:47 am |
|
Either "files" or "uploads" sounds good to me and I do like the idea of a configuration switch. You know me... love making this easy.  |
_________________ Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! |
|
|
 |
Guardian2003
Site Admin

Joined: Aug 28, 2003
Posts: 6799
Location: Ha Noi, Viet Nam
|
Posted:
Tue Apr 22, 2008 8:18 am |
|
uploads or files sounds good to me too |
|
|
|
 |
guidyy
Worker


Joined: Nov 22, 2004
Posts: 208
Location: Italy
|
Posted:
Tue Apr 22, 2008 9:58 am |
|
files or uploads are fine for me too. |
|
|
|
 |
kguske

|
Posted:
Tue Apr 22, 2008 10:52 am |
|
OK. I'll go with uploads. I will make a version available to those who wish to test for a week before adding to SVN. |
|
|
|
 |
jestrella
Moderator

Joined: Dec 01, 2005
Posts: 593
Location: Santiago, Dominican Republic
|
Posted:
Tue Apr 22, 2008 11:45 am |
|
definitely uploads is the best choice for this... even media can be a good one for this purpose. |
_________________ "For those whom have not reach the sky... Every mountain seems high"
Best Regards
Jonathan Estrella
http://about.me/jestrella04 |
|
|
 |
Guardian2003

|
Posted:
Tue Apr 22, 2008 12:21 pm |
|
looking forward to playing with the ajax inline editor |
|
|
|
 |
kguske

|
Posted:
Tue Apr 22, 2008 12:32 pm |
|
|
|
 |
Guardian2003

|
Posted:
Tue Apr 22, 2008 1:13 pm |
|
|
|
 |
montego

|
Posted:
Wed Apr 23, 2008 6:55 am |
|
kguske wrote: | PM sent. Enjoy... |
Holding out on me? lol.... |
|
|
|
 |
kguske

|
Posted:
Wed Apr 23, 2008 11:21 am |
|
|
|
 |
montego

|
Posted:
Wed Apr 23, 2008 11:38 am |
|
sorry, was just kidding. BTW, if I can get up enough energy today (home sick), I am planning on testing out the revised directory naming. I'll let you know if I find anything else too. |
|
|
|
 |
kguske

|
Posted:
Wed Apr 23, 2008 12:26 pm |
|
No problem. My main concern after testing is that changes to the documentation (namely, readme.txt and upgrade.txt). Because the changes aren't trivial, I want to make sure it's as clear as possible, so I definitely welcome suggestions for improving that  |
|
|
|
 |
kguske

|
Posted:
Mon Apr 28, 2008 5:16 pm |
|
I've installed it on a few sites, and it seems to be working well. I think I'll add it to the RN SVN, unless there are objections... |
|
|
|
 |
Guardian2003

|
Posted:
Mon Apr 28, 2008 5:32 pm |
|
I was hoping to get it installed on a site yesterday but the whole week-end went by way to quickly. |
|
|
|
 |
montego

|
Posted:
Tue Apr 29, 2008 5:17 am |
|
kguske, I've added issue#967 for the upgrade. |
|
|
|
 |
kguske

|
Posted:
Wed Apr 30, 2008 4:34 am |
|
|
|
 |
Guardian2003

|
Posted:
Wed Apr 30, 2008 5:30 am |
|
|
|
 |
kguske

|
Posted:
Wed Apr 30, 2008 5:40 am |
|
I really like the DHTML popups - you don't have to resize the Windows in FireFox anymore, and it seems much faster to add images, links, etc. |
|
|
|
 |
Guardian2003

|
Posted:
Wed Apr 30, 2008 7:31 am |
|
Yes, that is one of the features I was really looking forward to. I'm getting desperate now to get it installed but *things* keep getting in the way
Edit: fix my ridiculous typo(s) |
Last edited by Guardian2003 on Thu May 01, 2008 5:46 am; edited 1 time in total |
|
|
 |
montego

|
Posted:
Thu May 01, 2008 5:19 am |
|
So odd. I am on the latest SVN working copy and cannot use either the Browse or Upload options. This is on XAMPP 1.6.4 under PHP5 and on Windows XP Professional SP2. I am curious kguske what you are running this same build under since it is working for you. |
|
|
|
 |
|