Ravenice Problem

Involved Joined: Apr 06, 2008 Posts: 484

I came across this the other day but forgot all about it.There seems to be something in the Ravenice theme that is not quite right. I had installed a module i think and it messed up the page on IE only (the center column overlapped the right side blocks) .It also only happened in Ravenice all the other themes i tried displayed it properly.I will look back into this and post back here with exactly what happened.

Has anyone else had any problems with ravenice theme, or is anyone aware of any problems with ravenice.

Just wanted to bring it to your attention in case I forget again.

Posted: Fri Oct 31, 2008 9:43 pm

ok been doing some checking and noticed another problem.in

Code:




themes/Ravenice/theme.php

around line 112 find and remove:

Code:




if ($banners) {


      echo '<div id="head_ad">';


      echo ads(1);


      echo '</div>';


   };

note: the "page top" position is already set at line 99 so this should be completely removed.

ths should not be here and it is also referencing position 1 which is the left block by default in RN 2.3

registered · Posted: Sat Nov 01, 2008 12:31 pm

testy1, that is not an issue. ads(0) is intended to be a page top banner and ads(1) is considered to be a page header banner (which is usually to the right and in the header).

This overlap that you are talking about is related to the size of your browser window and the ads that you have.

Posted: Sat Nov 01, 2008 5:51 pm

In a fresh install ads(1) is listed as left block

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Montego, you never replied back to this one. Should this be submitted to Mantis?

Posted: Fri Nov 28, 2008 8:10 am

Sorry, Raven, got busy. I'll add an issue to our issue tracker to review the install package as it relates to the default ads(0) vs. 1.

Posted: Fri Nov 28, 2008 8:21 am

Was just a naming issue. Since Page Top and Page Header are the two most prevalently used positions for a site just starting out, that is what these two default ad positions were intended to provide, as examples.

The name has been corrected and SVN'd.

Posted: Fri Nov 28, 2008 10:19 am

Thanks!