topic listing - topicsmanager

Site Admin Joined: Aug 22, 2007 Posts: 1775

hey!

i have in many themes the same problem, if i use big sized topic-images. the topic-images are listed in the admin-section side by side and then the theme distorts.

in the file modules/topics/admin/index.php is the function topicsmanager. in this function is a echo call before start the content of the <td>. does this make sense or how can make it clean?

Code:




if ($count==0) echo '<tr>'; // HERE!!


echo '<td align="center">'


         .'<a href="'.$admin_file.'.php?op=topicedit&amp;topicid='.$topicid.'"><img src="'.$tipath.$topicimage.'" border="0" alt="" /></a><br />'





         .'<span class="content"><b>'.$topictext.'</b></span></td>';


   


         $count++;


         if ($count == 5) {


            echo '</tr>';


            $count = 0;


         }


      }


      if ($count > 0) {


         echo '</tr>';


      }


      echo '</table>';

if i moved the first <tr> to the next echo call, then i become all topic-images together listed. is not the best way but one topic always it exists after a fresh install.

Code:




if ($count==0) echo ''; // MOVED


echo '<tr><td align="center">' // HERE


         .'<a href="'.$admin_file.'.php?op=topicedit&amp;topicid='.$topicid.'"><img src="'.$tipath.$topicimage.'" border="0" alt="" /></a><br />'





         .'<span class="content"><b>'.$topictext.'</b></span></td>';


   


         $count++;


         if ($count == 5) {


            echo '</tr>';


            $count = 0;


         }


      }


      if ($count > 0) {


         echo '</tr>';


      }


      echo '</table>';

registered · Posted: Fri Nov 27, 2009 1:36 pm

neralex, the code that is in the distribution is correct and XHTML/HTML compliant. If you were to run your generated HTML through a validator, you would find that it is not valid. The code is written, on purpose, to show topics/images in two columns, hence the use of a two-column table layout. If you want to just show everything in one list, I would just take out all the table related tags, and either put each topic within tags or after each one, use maybe two tags.

Posted: Mon Nov 30, 2009 9:57 am

Yeah. a time ago I wondered also about this strange behavior but I had no issue with the default theme.
http://www.ravenphpscripts.com/posts18084-highlight-.html

Posted: Mon Nov 30, 2009 4:55 pm

montego: try it self ... & works not here to solve this issue! if you have one topic in your DB its all valid! i found no errors! if you don' t have a topic or you have all topics deteled, give it a chance for failure. but who has no topics and use the news-module? oO

Susann: ich bin bald bekloppt geworden, weil ich diese ganze Tabelle zerpflückt hatte, nur um den Fehler bzw. diese winzige Veränderung zu finden. Letztlich führt sie bei mir endlich zum Ziel und sofern man ein Topic hat, ist es auch valide.