Author |
Message |
bobbyg
Worker
![Worker Worker](modules/Forums/images/ranks/3stars.gif)
![](modules/Forums/images/avatars/47640777475ce61275311.jpg)
Joined: Dec 05, 2007
Posts: 212
Location: Tampa, Florida
|
Posted:
Fri Dec 11, 2009 2:33 am |
|
I installed the theme preview on RN 2.4.
The install instructions call for a change in mainfile.php, which I made.
It also called for a change in the YA module index.php file; which I did not make.
Everything works fine. The only thing missing was the theme.gif image; which I added one.
I have not checked it against the standards set for RN now, but it will run okay on RN 2.4. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
montego
Site Admin
![](modules/Forums/images/avatars/0c0adf824792d6d341ef4.gif)
Joined: Aug 29, 2004
Posts: 9457
Location: Arizona
|
Posted:
Fri Dec 11, 2009 6:01 am |
|
Cool. Thanks! |
_________________ Only registered users can see links on this board! Get registered or login!
Only registered users can see links on this board! Get registered or login! |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Fri Dec 11, 2009 7:42 am |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Fri Dec 11, 2009 8:04 am |
|
The only issue one might have is that the Theme Preview actually changes your theme and you will no longer be able to change the theme from Your Account. This is because of the difference in the modules between Php-nuke 7.4 and RavenNuke 2.4.
If you want to see it working (before you install it) you can go to www.bobbygs.info and preview themes. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
dad7732
RavenNuke(tm) Development Team
![](modules/Forums/images/avatars/gallery/blank.gif)
Joined: Mar 18, 2007
Posts: 1242
|
Posted:
Fri Dec 11, 2009 6:20 pm |
|
Quote: | f you want to see it working |
I give up, what do you push to see a preview? There is an image but if that's the "button" it doesn't work.
Never mind, it works WHEN you select a theme. I did that a few times but for whatever reason nothing happened .... Does now ... neat.
Cheeers |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
Palbin
Site Admin
![](modules/Forums/images/avatars/Dilbert/Dilbert_-_Dogbert_King.gif)
Joined: Mar 30, 2006
Posts: 2583
Location: Pittsburgh, Pennsylvania
|
Posted:
Fri Dec 11, 2009 11:54 pm |
|
Probably a JavaScript problem. Just from looking at the block i would assume as soon as you select a theme it should change. |
_________________ "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan. |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Dec 12, 2009 12:53 am |
|
You are correct. When you select the theme, it changes to that theme.
However, it does override the your account module for selecting a theme. If you have the preview block active but do not use it, then you can select a theme via your account.
The changes for the modules/your-account/index.php listed in the install instructions can not be applied because the code referenced is not there anymore.
Maybe someone more familiar with changes in all the upgrades for Ravennuke can make suggestions to the install instructions regarding the Your_Account module. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
Palbin
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Dec 12, 2009 2:20 am |
|
Probably have to delete the cookie when saving a new theme in YA. I'll see if I can take a look sometime. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
nuken
RavenNuke(tm) Development Team
![](modules/Forums/images/avatars/3234de284ee21bd39eecd.jpg)
Joined: Mar 11, 2007
Posts: 2024
Location: North Carolina
|
Posted:
Sat Dec 12, 2009 6:47 am |
|
I think when I installed the block on my test site, I did not need to do any changes to RavenNuke(tm) at all. It seems to me the changes were already made to the core files and all I had to do was activate the block. |
_________________ Only registered users can see links on this board! Get registered or login! |
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Dec 12, 2009 7:07 am |
|
nuken, You might be right on the changes for the mainfile.php. I was following the instructions included in the download. I did not compare it line for line. It did look quite similiar at a quick glance.
However, one might not like the idea that it seems to disable the change capability within the YA module. I don't see it as a problem, but then you have a area of coding that is non-functional. I think it would be presented better if the switching themes was working in both areas. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
nuken
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Dec 12, 2009 7:17 am |
|
On my test site, the theme select in your account is not affected. I have only tried it logged in as admin though. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Sat Dec 12, 2009 7:30 am |
|
Supposedly the change that was suppose to be applied to the modules/your-account/index.php listed in the install instructions would allow changing the theme that was set by the preview block. {code for Ravennuke 2.4 is completely different than that for php-nuke 7.4 which these instructions were for}.
Actually the term 'Preview' is incorrect because it actually changes the theme. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
bobbyg
![](modules/Forums/images/avatars/gallery/blank.gif)
|
Posted:
Mon Dec 14, 2009 7:22 am |
|
Made changes to block_Preview_theme.php to make it CSE HTML compliant. |
|
|
|
![](themes/RavenIce/forums/images/spacer.gif) |
|