News>>Comments>>Search Bug? (SOLVED)

Posted: Wed Jun 30, 2010 8:08 pm

Clicking on the search comments link in the default News module "comments" section has odd behavior. I believe its intent was to select comments as the search criteria but instead its inserting "Comments" into the search field.

Can someone clarify the intent of the link?
Can someone verify the behavior with a default theme and install?

Posted: Thu Jul 01, 2010 9:41 am

I am not seeing this using a default install and the ravenice theme. The intent of the link seems to be to search the comments for a given string. I believe there is code in the various themes so you could have a buggy theme. Can you try ravenice and see if the same behavior carries over? Or tell us what theme you are using.

It's been a generic problem in the past that we have idiosyncratic code in multiple themes for things like search boxes. I guess the other side of this coin could be to call this "flexibility" but it causes a maintenance nightmare. Better to standardize with the capabilities to override if someone in a theme REALLY has to do the search differently.

Posted: Thu Jul 01, 2010 7:48 pm

No I get the same thing with RavenIce Search Discussion adds comments to the field instead of selecting comments to search in. Not a big deal just flaky. I'll check it on www.ravennuke.com when it comes back online.

Posted: Fri Jul 02, 2010 7:36 pm

Seems to happen only with short links enabled or at least does not happen on my localhost with short links not enabled. Using all the same files.

Posted: Fri Jul 02, 2010 8:24 pm

ahh i see what you are saying, and good catch. In looking at the .htaccess

RewriteRule ^search-([/:\-\'{}()\,\._&a-zA-Z0-9+=\ ]*)-([a-zA-Z0-9_-]*).html modules.php?name=Search&query=$1&author=$2 [L]

RewriteRule ^search-comments-([0-9]*).html modules.php?name=Search&type=comments&sid=$1 [L]

these two rewrites are at odds with each other, at least in the order they are in because the first one will also match the comments link. Try editing your .htaccess so that the comments rewrite comes first.

Code:

#Search


RewriteRule ^search-([a-zA-Z0-9]*)-([0-9]*)-([0-9]*)-([/:\-\'{}()\,\._&a-zA-Z0-9+=\ ]*)-([a-zA-Z]*)-([0-9]*).html modules.php?name=Search&author=$1&topic=$2&min=$3&query=$4&type=$5&category=$6 [L]


RewriteRule ^search-([a-zA-Z0-9]*)-([0-9]*)-([0-9]*)-([/:\-\'{}()\,\._&a-zA-Z0-9+=\ ]*)-([a-zA-Z]*).html modules.php?name=Search&author=$1&topic=$2&min=$3&query=$4&type=$5 [L]


RewriteRule ^search-author-([a-zA-Z0-9]*).html modules.php?name=Search&author=$1 [L]


RewriteRule ^search-comments-([0-9]*).html modules.php?name=Search&type=comments&sid=$1 [L]


RewriteRule ^search-([/:\-\'{}()\,\._&a-zA-Z0-9+=\ ]*)-([a-zA-Z0-9_-]*).html modules.php?name=Search&query=$1&author=$2 [L]


RewriteRule ^search-([0-9]*).html modules.php?name=Search&query=&topic=$1 [L]


RewriteRule ^search-users.html modules.php?name=Search&type=users [L]


RewriteRule ^search.html* search.html [L]

that's all you have to change it think Wink

i couldnt reproduce within the search module itself so i don't think you need to change any shortlink files, although i could be wrong, lol Rolling Eyes

Posted: Sat Jul 03, 2010 7:05 am

spasticdonkey you have an eye! I might have never found that! Thanks both of you for taking the time to reply. Looks like a winner!

Posted: Wed Jul 07, 2010 3:39 pm

Phew. Just as confirmation, I don't use shortlinks. I just haven't made the time to figure it out and on the sites I run I don't place a ton of priority of search engine ratings.