Suggestion - some improvements

Posted: Sat Aug 28, 2010 7:47 am

Is about db.php and mysql.php

on error, db.php will put default error messages, but not in a logic way.
If it can't connect to server, is logic it can't select db and can't check config table.
Instead to see all 3 errors even there is one, I changed db.php to show exact error only.
For this class sql_db (mysql.php) was reworked, so now is called sql_connect
and distinguish between connect and select_db.

Code:

   $db = new sql_connect($dbhost, $dbuname, $dbpass, false);


   if (@!$db->db_connect_id) {


    $mysqlErrorConnectServer = true;


  }


   else {


     if (@!$db->sql_select_db($dbname)){


     $mysqlErrorConnectDb = true;


    }


  }


  if(!$mysqlErrorConnectDb) {


     if (@!$db->sql_query('SELECT Default_Theme FROM '.$prefix.'_config WHERE 1;')) {


        $mysqlErrorConfigTableMissing = true;


     }


  }

Also removed references to db name in db select error and mysql_error() from config table missing error.
I don't want to be visible to anyone in case of error.

Other fix is URL from config error, in case user input in browser URL/index.php
then result is a invalid link to install file.
So replace

Code:

<a href="http://'.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'].'INSTALLATION/installSQL.php">

with

Code:

<a href="http://'.$_SERVER['HTTP_HOST'].'/'.basename(getcwd()).'/INSTALLATION/installSQL.php">

And finally I added a new file called install.php, is just allow to access installSQL.php and setup.php from same place.
Is easier to point browser to URL/install.php than to URL/INSTALLATION/installSQL.php...

Only registered users can see links on this board! Get registered or login!

Hope it helps.

registered · Site Admin Joined: Jun 04, 2004 Posts: 6437

Haven't had a chance to review this, but hopefully Raven can.