When making comment - bad link - FIXED!

Hangin' Around Joined: Jan 22, 2004 Posts: 31

I have a problem with 6.5. The same is with original distro and the patched one.

When I add a comment to News (doesn't depend - both plain text and html) when I insert:

Code:

Czytaj: <a href=<a href=http://pawica.net><u>TRATATATATATA</u></a>

In the preview it's OK, when I post it I get such a linkadress:

Code:

http://pawica.nettitle='http//pawica.net'

which I have to correct in the database.

Anybody can help? Crying or Very sad

Andrzej

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Do you really have?

Code:

Czytaj: <a href=<a href=http://pawica.net><u>TRATATATATATA</u></a>

If so, it should be

Code:

Czytaj: <a href="http://pawica.net"><u>TRATATATATATA</u></a>

Posted: Mon Sep 06, 2004 11:54 am

Yes you a right, but I wrote only the link, that I see in the browser adress bar after clicking on the link (and the error message of course)

It looks like in the comment:
TRATATATATATA [pawica.net]

but the adress under this text is
http://pawica.nettitle='http//pawica.net'

After looking in the preview it's OK, then it makes sth like that messraven

Andrzej

PS I've made such a test comment on this site, and there is the same effect. Look:
http://www.ravenphpscripts.com/modules.php?name=News&file=article&sid=496

Posted: Mon Sep 06, 2004 12:02 pm

I just did a test comment with a hyperlink and it worked perfectly. Please post the code here as a code block to show me how you are typing it.

Posted: Tue Sep 07, 2004 12:25 am

I type it :

Code:




Czytaj: <a href=http://www.prawica.net><u>Prawica.net</u></a>

I did it in this way in your news. Did you see?

Andrzej

Posted: Tue Sep 07, 2004 4:11 am

Yes, it is an error and I will look further into it. I have no answer at this time. Are you using GT or NG?

Posted: Tue Sep 07, 2004 6:36 am

The error is in modules/News/comments.php in the function format_url(). This line is the line that is in error. I will be testing a fix as soon as I can.

Code:

       $comment = ereg_replace(">$links[$i]</a>", "title='$hrefs[$i]'> $links[$i]</a>$href", $comment);

Posted: Tue Sep 07, 2004 6:51 am

Replace

Code:

      $comment = ereg_replace(">$links[$i]</a>", "title='$hrefs[$i]'> $links[$i]</a>$href", $comment);

with

Code:

       $comment = ereg_replace(">$links[$i]</a>", " title='$hrefs[$i]'> $links[$i]</a>$href", $comment);

Posted: Tue Sep 07, 2004 7:45 am

Thank yuo Raven Very Happy

You are great !
RavensScripts

It works! You are making PHPNuke better and better!

What do you think - is it possible to make such a script in comments.php, that the user, who only pastes link - like that:

Code:




Read:


http://www.wyborcza.pl/howto.html

(a lot of non-expirienced do it) to make it live? When he posts it in the plain text mode? Now it is only a text. Could it be in the comment clickable?

Thanks again

Andrzej
PS. But is it possible, that this error is still present from version 6.5???
Bang Head

Posted: Wed Oct 20, 2004 9:38 am

The same change you need to do in comments.php on surveys module

Andrzej