Can't edit RSS block url

Regular Joined: Nov 05, 2006 Posts: 96

maybe someone can try to recreate this...

I created a new block through the administration page and pointed it to:
http://twitter.com/statuses/user_timeline/10849272.rss

the block displays fine, but it added a "read more..." link that doesn't exist in the feed. so i went to make a change to the URL through block administration, and now anytime i save the URL it gets saved as:

http://twitter.com/http://twitter.com/statuses/user_timeline/10849272.rss

Posted: Wed Dec 12, 2007 6:01 pm

I will take a look. We recoded much of blocks.php for 2.20 so I will use your report to test this. It might take a couple days to get back to you but I will.

Posted: Mon Dec 17, 2007 10:20 am

Sorry for the delay. I have just taken a look at this with respect to what we have in RN 2.20, that is in the pipeline for release soon. I cannot duplicate the double http: you are seeing after you save a change to the link so maybe we have eliminated that. What exact change to the URL did you try to make thru block admin?

The read more "problem" you are seeing is just the way the headlines function in mainfile works with RSS blocks. I believe Kguske is intending to eventually replace this but for right now it is still a "problem" or "feature" depending on how you want to look at it. What happens is that the headlines function rummages thru all the feeds in your feed url and then at the end it does this:

Code:

    $siteurl = 'http://'.$rdf['host'].dirname($rdf['path']);


    if (($cont == 1) OR (!empty($content))) {


        $content .= '<br /><a href="'.$siteurl.'" target="_blank"><b>'._HREADMORE.'</b></a></font>';

For something like Nukescripts where the feed url is: "http://www.nukescripts.net/backend.php" this results in a read more link of http://nukescripts.net" which will take you to the home page for Nukescripts. Where the feed link is something like "http://twitter.com/statuses/user_timeline/10849272.rss" the read more link is going to wind up being "http:/twitter.com/statuses/user_timeline" based on how the $siteurl is parsed. You might be able to make the problem go away by placing your rss file directly below the directory you want to point them at with read more. And, as I say, read more is going to be there if any feeds are found.

registered · Site Admin Joined: Jun 04, 2004 Posts: 6437

Yes, nukePIE will replace the standard feed block processing with one that handles modern feed formats and has additional options. At this point, though, I haven't planned to replace the READ MORE function.

FKelly is correct: basically, READ MORE provides a link to the domain that generated the feed so you can find more news. The read more function is commonly used with feed readers, but maybe we can figure out a way to provide an override URL for the read more function so it doesn't point (for example) to FeedBurner for more news from nukeSEO.com...

Posted: Tue Dec 18, 2007 8:14 am

I suppose in the current implementation we'd have to provide an "activate read more" field for each RSS block and then a "read more url". Blocks.php would have to be modified to allow those fields to be maintained and the headlines function (which I believe is duplicated or triplicated within Nuke) would have to be modified to look at those fields. The blocks table would have to be modified and then all file maintenance which updates that table would have to be looked at to make sure the field names and values were corrected. And we'd have to revise the installation SQL. So it's not going to happen short term I don't think but maybe we can build it into the implementation of NukePIE in the future.

Posted: Thu Dec 20, 2007 3:46 pm

Just to follow up. I was looking thru the SQL log file that will be optional with Ravennuke 2.20. I have this in my test system where I was trying out the RSS file that was listed at the beginning of this thread. The log shows:

Quote:

December 17, 2007, 10:57 am 1064 : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'm hungry but too cheap to pay to eat out for lunch. But I'm off for a week and ' at line 1
SQL was: update nuke_blocks set bkey='', title='Timeline', content='<big>·</big> <a href="http://twitter.com/sixf00t4/statuses/505230092" target="new">sixf00t4: just got done partying and drinking. 6 beers, 1 shot of saki, 1 jack and coke...</a> <big>·</big> <a href="http://twitter.com/sixf00t4/statuses/501148522" target="new">sixf00t4: I'm hungry but too cheap to pay to eat out for lunch. But I'm off for a week and going to Ft. Myers!</a> <big>·</big> <a href="http://twitter.com/sixf00t4/statuses/497262862" target="new">sixf00t4: Got to work 1 hour early; think i'll leave early?</a>

I'm not an expert on formatting RSS files by any means but I believe the single quotes in the text need to be encoded in some way? No?

registered · Posted: Thu Dec 20, 2007 6:05 pm

Looks like there is a missing addslashes()? If check_html() is used on the user input, it will automatically check to see if magic_quotes_gpc() is on, and, if so, it will do a stripslashes() - this is appropriate behavior. However, I have seen elsewhere within the admin code where FB had forgotten to ensure the escaping was done prior to the insert/update.

If check_html() is not being called, it is also possible that magic quotes are not on, so you have to check for that and then use addslashes() prior to calling the db.

It is also possible to use the crazy stripslashes(FixQuotes()) mumbo-jumbo, which surprisingly works regardless of whether magic quotes is on or not (for the most part).