Everything is centralized with IE, Firefox shows it ok.

Worker Joined: Aug 02, 2004 Posts: 165

// After a v2.30 upgrade:

Do you have any idea what could cause IE to show all menus, news, forum content aligned as "centralized".

In Firefox everything is like it should (justify left).

Posted: Sat Oct 25, 2008 4:59 am

At a guess I would say you are using an old theme with invalid markup.

Posted: Sat Oct 25, 2008 8:17 am

Guardian2003 wrote:

At a guess I would say you are using an old theme with invalid markup.

I tested with other theme and it worked correctly! I'll have to check my theme again from line by line.

Posted: Sat Oct 25, 2008 2:08 pm

Use the Firefox 'Developer' plug-in to help you locate errant theme code, it is quicker than trawling through it line by line and there are buttons to instantly validate both the HTML and CSS.

registered · Posted: Sat Oct 25, 2008 2:27 pm

Also, you must have come from an earlier release (i.e., prior to XHTML). There are numerous forum posts here on this exact same issue. I am sure you will find your answers there... Wink

Posted: Sat Oct 25, 2008 2:34 pm

montego wrote:

Also, you must have come from an earlier release (i.e., prior to XHTML). There are numerous forum posts here on this exact same issue. I am sure you will find your answers there... Wink

I succeed to solve this by replacing at one place
<center> to <table align=\"center\" width...

That solved the IE layout problem! Lets hope that it was only problem with theme section...

speedtype

Ps. I thought that 2.02.02 -> 2.30 upgrade would be much easier than what I have met now... But as usually -> You should count that upgrade is never easy to do! Wink

Posted: Sat Oct 25, 2008 2:44 pm

crypto wrote:

Ps. I thought that 2.02.02 -> 2.30 upgrade would be much easier than what I have met now... But as usually -> You should count that upgrade is never easy to do! Wink

Which is why we always recommend doing a test run using XAMPP first. Wink

Posted: Sat Oct 25, 2008 2:48 pm

crypto wrote:

Ps. I thought that 2.02.02 -> 2.30 upgrade would be much easier than what I have met now... But as usually -> You should count that upgrade is never easy to do! Wink

It would have been easier if you were to keep up with the upgrades as we release them. You took quite a leap there. Wink

I think most of the issues we run into were related to going to XHTML 1.0 Transitional. It definitely forces better coding practices and, yes, a few "tricks" are needed to ensure certain javascript code to work properly as well.

Posted: Sat Oct 25, 2008 3:04 pm

montego wrote:

It would have been easier if you were to keep up with the upgrades as we release them. You took quite a leap there. Wink

I think most of the issues we run into were related to going to XHTML 1.0 Transitional. It definitely forces better coding practices and, yes, a few "tricks" are needed to ensure certain javascript code to work properly as well.

Yep, regular updates would be the best way to keep the code base up-to-date. However, I have edited many "core files" so updating means always lot's of manual work (I cannot just replace the files).

This might be a off-the-topic, but have you measured performance of your rewriten code vs. the original phpnuke code (not just a security side)? If you have, what was the result of the test?

Posted: Sat Oct 25, 2008 3:08 pm

crypto wrote:

This might be a off-the-topic, but have you measured performance of your rewriten code vs. the original phpnuke code (not just a security side)? If you have, what was the result of the test?

I'm not sure anyone has benchmarked it, but it is noticeably faster!

Posted: Sat Oct 25, 2008 3:30 pm

RN code versus standard phpNuke?
A heck of a lot faster. But it's not just speed, it is also about wasting less resources on the server.
I did a benchmark some time ago, it wasn't very scientific as I only used the generated page load time in the fisubice theme but even so, the difference was quite remarkable.

Posted: Sun Oct 26, 2008 2:58 pm

Much of the slow down was just how many errors (warnings mostly) PHP had to process in the background with the older PHP-Nuke code. Man it was a complete mess. Although these errors were almost never noticed due to people's PHP settings, PHP was still slowing down because of them. Also, we have done some loop tweaking here and there as well as a bunch of changing in how we concatenate strings. In addition to this, even browser render times are better due to having XHTML compliant code and now with a few CSS-driven themes, with so much less mark-up... you get the drift. Wink

Posted: Thu Oct 30, 2008 1:13 am

Yep, it's good to fix invalid or ineffective code Smile

.

Do you co-operate in anyway with PHPNuke staff (e.g with NukeLite etc.)?

Posted: Thu Oct 30, 2008 2:34 am

crypto wrote:

Do you co-operate in anyway with PHPNuke staff (e.g with NukeLite etc.)?

Now you've gone and done it!

Posted: Thu Oct 30, 2008 3:08 am

Guardian2003 wrote:

Now you've gone and done it!

Touchy subject?

Posted: Thu Oct 30, 2008 4:04 am

The community as a whole used to provide fixes for PHPNuke and there were small number of individuals that went out of their way to resolve as many problems as possible. The fixes provided by those individuals were either;
not included in nuke
included in nuke but the authors were not credited
included in nuke and the authors credited until those credits were removed in subsequent releases
the author of nuke claimed 'he' had done the fixes and along the way introduced even more bugs and security problems
or fixes were made and then taken out in subsequent releases.

He did offer support at one stage but he quickly closed his forums when people complained and stopped answering emails.

The final straw came last year when people who had paid for 'lifetime' and other advertising at his site found their ads had been removed. Shortly after than, nuke was sold (around Oct/Nov last year) to an unknown entity and there has been no further releases since then - though someone is still getting $12 a pop for buying into the 'club'.

Involved Joined: Apr 06, 2008 Posts: 484

I have also set up a club.There are no benefits what so ever....in fact if you send me your code I will mess it up as much as possible and send it back...

oh and my club is only $8 :clap:

Posted: Fri Oct 31, 2008 2:35 am

Guardian2003 wrote:

The community as a whole used to provide fixes for PHPNuke and there were small number of individuals that went out of their way to resolve as many problems as possible. The fixes provided by those individuals were either;
not included in nuke
included in nuke but the authors were not credited
included in nuke and the authors credited until those credits were removed in subsequent releases
the author of nuke claimed 'he' had done the fixes and along the way introduced even more bugs and security problems
or fixes were made and then taken out in subsequent releases.

He did offer support at one stage but he quickly closed his forums when people complained and stopped answering emails.

The final straw came last year when people who had paid for 'lifetime' and other advertising at his site found their ads had been removed. Shortly after than, nuke was sold (around Oct/Nov last year) to an unknown entity and there has been no further releases since then - though someone is
still getting $12 a pop for buying into the 'club'.

Thanks, this information was very interesting!