Author |
Message |
Dawg
RavenNuke(tm) Development Team

Joined: Nov 07, 2003
Posts: 928
|
Posted:
Wed Dec 31, 2008 8:03 am |
|
I upgraded my main site last night. Most Everything went smooth. The only issue I have found is in IE....I have no banners. They work as expected in Firefox.
I have another site running on the same code base with no problems.
I have run File Compare on index.php, theme.php, header.php, javascript.php and several more and for the life of me I can not think of what it could be. Any suggestions?
Dave |
|
|
|
 |
jakec
Site Admin

Joined: Feb 06, 2006
Posts: 3048
Location: United Kingdom
|
Posted:
Wed Dec 31, 2008 8:09 am |
|
Can you confirm what theme you are using. If it isn't a stock RN theme, please try fisubice and report back.
Cheers |
|
|
|
 |
Dawg

|
Posted:
Wed Dec 31, 2008 8:20 am |
|
Jake,
It is a custom theme. I am shocked that it did NOT work in fisubice as well. Hmmm...Something is amiss.
So in both my custom theme and fisubice....banners are displayed in Firefox but not in IE.
Any suggestions? |
|
|
|
 |
Guardian2003
Site Admin

Joined: Aug 28, 2003
Posts: 6799
Location: Ha Noi, Viet Nam
|
Posted:
Wed Dec 31, 2008 4:42 pm |
|
Browser security settings? |
|
|
|
 |
Dawg

|
Posted:
Wed Dec 31, 2008 4:56 pm |
|
I would not think so. This site is a "Trusted Site" and javascript is turned on.
I am stumped...
Dawg |
|
|
|
 |
Guardian2003

|
Posted:
Wed Dec 31, 2008 5:14 pm |
|
Can you PM the site url so I can have a look on my wifes PC (she has IE but I won't have it anywhere near mine ) |
|
|
|
 |
jestrella
Moderator

Joined: Dec 01, 2005
Posts: 593
Location: Santiago, Dominican Republic
|
Posted:
Wed Dec 31, 2008 6:17 pm |
|
IE and its eternal developer headaches... and IE8 still more of the same... think is time for a 360 degree change in IE development roadmap  |
_________________ "For those whom have not reach the sky... Every mountain seems high"
Best Regards
Jonathan Estrella
http://about.me/jestrella04 |
|
|
 |
Dawg

|
Posted:
Fri Jan 02, 2009 8:04 pm |
|
Well Overall I have it working.
Is there a "Switch" in this sled for making the Ads Vistors only? I have not seen one...but that is what I have got. Vistors can see them....registered users can not. I bet I am doing something silly!
Dawg |
|
|
|
 |
Palbin
Site Admin

Joined: Mar 30, 2006
Posts: 2583
Location: Pittsburgh, Pennsylvania
|
Posted:
Fri Jan 02, 2009 8:15 pm |
|
I know some of the guys use code like this on their sites. Maybe it slipped in there by accident. |
_________________ "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan. |
|
|
 |
jakec

|
Posted:
Sat Jan 03, 2009 4:56 am |
|
Is this a banner in the header of the theme? or a block?
Obviously a block can be set to Anonymouse users only. If it is in the header check your theme, are you still using the custom theme? If you are try using a stock theme. |
|
|
|
 |
Guardian2003

|
Posted:
Sat Jan 03, 2009 5:57 am |
|
If the ad is being displayed from the theme then it is visible to everyone, unless they are 'Subscribed'. The *nuke default (I think) is to test for is_paid() if that is 'true' then ads are not shown.
I have some paid text link ads on my site which appear in the footer but I wrap them in both an is_user and is_admin test so they only appear to anonymous users (search engines). |
|
|
|
 |
Dawg

|
Posted:
Mon Jan 05, 2009 7:23 am |
|
This here seems to be the issue....
In Mainfile around line 1823....
Code:
if (paid()) {
return;
}
|
What else does that do?
If I comment it out....all the ads show as expected.
I would think a switch is needed for this in either RNConfig or in Preferences.
Dawg |
|
|
|
 |
Palbin

|
Posted:
Mon Jan 05, 2009 8:03 am |
|
If you comment that out ads will show all the time no matter what. All that does is return true or false if you have a subscription. If it is true no ads because of the return.
I don't see how this could be an ie/ff issue based on the core code. It has to be a theme or cookie/cache issue. |
|
|
|
 |
dad7732
RavenNuke(tm) Development Team

Joined: Mar 18, 2007
Posts: 1242
|
Posted:
Tue Jan 20, 2009 9:23 am |
|
Ok, I tried to hold back this stupid question .. How do you subscribe a user? I see the radio button "subscribe to newsletter" and that's all the "subscribe I see anywhere ...
Cheers
Yikes, never mind, found it. It's on a per user setting. Never noted that before as I have never used that feature/function.  |
|
|
|
 |
Palbin

|
Posted:
Tue Jan 20, 2009 10:17 am |
|
Not to many people understand the subscription system. Including me  |
|
|
|
 |
dad7732

|
Posted:
Tue Jan 20, 2009 10:23 am |
|
I do now after actually "READING" what is presented. Subscribe a user, then for each "block" you can disable it for "subscribed" users. This can come in handy if your site has a lot of ad blocks, et al, that users don't want to see, so just subscribe them and choose accordingly in the block preference.
Cheers |
|
|
|
 |
wHiTeHaT
Life Cycles Becoming CPU Cycles

Joined: Jul 18, 2004
Posts: 579
|
Posted:
Sat Jul 18, 2009 5:11 am |
|
i have infact the same issue , however if i comment the
Code:// if (paid()) {
// return;
//}
|
function ,in the
Code: function ads($position) {
global $prefix, $db, $admin, $sitename, $adminmail, $nukeurl;
$position = intval($position);
// if (paid()) {
// return;
//}
|
Nothing changes for me.
When i test in IE , sometimes ie doesnt load the adds at all , sometimes it shows 1 add or all 4.
There's defenitly someting wrong that IE cant handle.
In FF al is perfect.
You can check it out by following the WWW button down here
Grtzzz wHiTeHaT  |
|
|
|
 |
wHiTeHaT

|
Posted:
Sat Jul 18, 2009 5:28 am |
|
I just did a discovery that when you have for each position only 1 banner that is active, this bug is for real in IE.
However if have 2 or more , IE doesnt show any bug.
My conclusion is that the query for the banner function isnt 100% correct , there isnt a check for when there's only 1 banner per position. it only checks if there's more as 1.
Grtzz wHiTeHaT
EDIT: i was to early with my what as i thought , solution.
When navigate inside the page all seems fine , but when refresh the page..it act as before |
|
|
|
 |
|