module faq

Regular Joined: Jun 04, 2004 Posts: 84 Location: Germany

since the fckeditior is integrated & and used also in the faq module I think the following line in the index.php breaks XHTML because the editor set normaly the p tag and therefore it would be twice.

in the function ShowFaqAll

Code:

 .'<p align="justify">'.$answer.'</p>'

Brujo

Posted: Sun Mar 22, 2009 1:19 pm

What is the exact error that the validator is showing? Can you post the HTML code that is displayed on the page rather than from the files.

Posted: Sun Mar 22, 2009 2:19 pm

OK, so I created a new test Categorie with the Question "Test Question" and the Answer "Test Answer" with the fckeditor

here the snip from Sourcecode

Quote:

Test QuestionTest Answer[ <a href="#top">Zurück zum Anfang</a> ]

tidy says: Warning inserting implicit 
xhtml validator: document type does not allow element "p" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag.

as I understand the 2 p tags are the problem

Brujo

Posted: Sun Mar 22, 2009 4:50 pm

We could just remove it and people will just have to do there own justification?

Posted: Sun Mar 22, 2009 7:04 pm

Just an opinion, but I vote for removing it, I actually go back and remove them manually anyways as it looks better without the p.

Posted: Sun Mar 22, 2009 10:56 pm

Probably replace it with a div tag.

Posted: Tue Mar 24, 2009 3:38 am

i tested it without the p & justify tag and with the div, both are fine and valid and i personal tend to the div tag.

Another small issue is in the function ShowFaq with the ">"

Code:

        


._CATEGORY.': <a href="modules.php?name='.$module_name.'">'._MAIN.'</a> -> '.$categories





should be:


._CATEGORY.': <a href="modules.php?name='.$module_name.'">'._MAIN.'</a> -&gt; '.$categories

and another one in the modules/Topics/index.php

Code:

        


echo '<big><strong>&middot;</strong></big>&nbsp;<a href="modules.php?name=News&amp;new_topic='.$topicid.'"><b>'._MORE.' -->;</b></a>';





should be:


echo '<big><strong>&middot;</strong></big>&nbsp;<a href="modules.php?name=News&amp;new_topic='.$topicid.'"><b>'._MORE.' --&gt;</b></a>';

Brujo

Posted: Thu Apr 02, 2009 5:46 pm

Fixed and fixed! Thanks for the input.

Posted: Sat Apr 04, 2009 12:05 am

@palbin, thanks good to know that also the small issues are now fixed

Brujo