No language fall-back in a few modules

registered · Posted: Sun Jul 31, 2011 7:13 pm

I noticed the issue while trying to test my greek HTML Newsletter language files and when I hit the admin section, I had several errors which pointed to several modules with hard-coded "assumptions" of language file inclusions.

The modules where I found issues in the case.php are:
- Advertising
- Encyclopedia
- FAQ

There could be other issues, so might be good to review each module and its admin (if relevant).

Taking advertising as the example, here is the code:

Code:

include_once('modules/' . $module_name . '/admin/language/lang-' . $currentlang . '.php');

As you see, no fall-back. Here is an example of a module (Content) which does have fall-back:

Code:

if(file_exists(INCLUDE_PATH.'modules/'.$module_name.'/admin/language/lang-'.$currentlang.'.php')) {


   include_once(INCLUDE_PATH.'modules/'.$module_name.'/admin/language/lang-'.$currentlang.'.php');


} elseif(file_exists(INCLUDE_PATH.'modules/'.$module_name.'/admin/language/lang-'.$language.'.php')) {


   include_once(INCLUDE_PATH.'modules/'.$module_name.'/admin/language/lang-'.$language.'.php');


} else {


   include_once(INCLUDE_PATH.'modules/'.$module_name.'/admin/language/lang-english.php');


}

I would think that it would be better to have a consistent function/object (API) to call to handle pulling the right language file depending upon all the many factors which come into play.

Posted: Sat Aug 06, 2011 2:40 am

It's been a while but isn't the function get_lang($module) supposed to include the correct user/admin, module dependent language file automatically??

Posted: Sat Aug 06, 2011 7:56 am

That may be true, but the above mentioned modules are not using a function. Wink

They are hard-coding the language file based upon $currentlang.

Posted: Sat Aug 06, 2011 10:04 am

I will look into it.