[solved]Converting RavenIce theme to update the Black edits

Posted: Sat Aug 04, 2012 8:47 am

I am having some issues pinning down the cause of some banner and block corners maintaining the original RavenIce colors and possibly images. I have been over it a few times and while I am sure I am just missing something I cannot help but wonder if maybe I am not and there has been some change I am not aware of or am overlooking.

Edit. Sometimes I just need to stop Bang Head

Posted: Sat Aug 04, 2012 2:28 pm

The corners are referenced in several places, I would check these declarations in your style.css

.article_top div {}
.article_top {}
.article_bot div {}
.article_bot {}
.inv_article_top div {}
.inv_article_top {}
.inv_article_bot div {}
.inv_article_bot {}
.block_top div {}
.block_top {}

Posted: Sat Aug 04, 2012 2:42 pm

Thank you Spastic,

The problem turned out to be (aside from lack of sleep) that I had started from scratch from the released RavenIce and forgot to swap out my black images for the blue set Embarassed

. I knew I was tired, but that was very basic stuff to miss Shocked

Posted: Sat Aug 04, 2012 2:57 pm

lol, I've been there Smile

Posted: Sun Aug 05, 2012 8:47 am

I think if I actually spent more time (aka practice regularly) I may have better luck. I swear I went through file compare on each file I edited 3-5 times that night. All the time thinking, I am too tired, double check tomorrow, but nooooooo - I just kept going. Razz

This brings up a topic, I am using Notepad++ plugin called compare. I love it, but when trying to compare the contents of lets say a theme directory I would love to compare directory->directory, any ideas on that? It would make life so much easier!

What I have been doing to eliminate potential errors, is that each time a new RN is released, I start from scratch and copy my old edits to the new files (colors links to theme files etc.) and make a mental note of other code changes. An improved file comparison tool would make culling through initial files to edit, much more efficient.

Posted: Sun Aug 05, 2012 9:37 am

I use notepad++ as well but have never used the plugin you speak of.. I use winmerge (free), it works pretty good and has options for comparing single files or entire directories.. Easy to merge differences from one side to the other, so it's been essential for me at upgrade time Smile

I have also heard good things about beyond compare (not free)

http://winmerge.org/
http://www.scootersoftware.com/index.php

One note about comparison that I noticed from RN 2.4 to 2.5, some of the files have changed end-of-line (EOL) from Windows to UNIX format... Files will not compare properly like that, so you will need to convert EOL so they match in some cases. This is an example of what to watch for in winmerge with EOL

I usually just change the EOL in notepad++, save, and run the comparison again. There may also be an option for this in the comparison tool...

Posted: Sun Aug 05, 2012 9:54 am

Thank you so much, great information!! I will check out the options as well as EOl which I was completely unaware of (and did not notice in the theme files), I simply never looked. I hope that I do not have the older format uploaded in my theme!

Posted: Sun Aug 05, 2012 10:33 am

At this point EOL shouldn't matter too much except for comparing files. I imagine the EOL changes in rn2.5 were probably unintentional as we have some dev's using linux and some using windows... there were also files merged into 2.5 from a future RN version that may have been in UNIX EOL. I looked over our roadmap and didn't see anything related to a EOL standard specifically, but I would venture a guess that UNIX style will be the recommended EOL when we make the jump to utf8 in the next major release. But one of the veterans would have to confirm that.

btw, I remember scratching my head with winmerge on the first run. Just hit the folder icon and select the directories to compare. Double click on diff files to open in a new tab, and right click the differences to merge to the "other side". Still might have to stare at the changes awhile, but once you get used to it you'll wonder how you did it the other way Wink

On a side note you can see the EOL and Encoding (which will be more important in the future) for the current file, at the bottom of the window in notepad++.

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Actually, whether windows or *nix, you/we should always be using *nix line ending. It's been part of our standards from way back Wink

registered · Posted: Sun Aug 12, 2012 9:31 am

We are an open book. Smile

See here:

http://rnwiki.ravennuke.com/wiki/RNTeam:Coding_Standards

Posted: Mon Aug 13, 2012 12:48 am

Perfectamundo - Thanks!