sending abuse mail issue

Site Admin Joined: Aug 22, 2007 Posts: 1775

In the nukesentinel.php of RN25 exist an issue for sending abuse mails. The header is broken or better the title of the sending adress. Here an example from a incoming sentinel mail:

Code:

tm <""myadmin\"@mail.tldrnX-Mailer: NukeSentinel">

After a look inside the nukesentinel.php i have found an issue with single-quotes in this line:

Code:

@mail($admincontact[$i], $subject, $message, 'From: ' . $adminmail . '\r\nX-Mailer: ' . _AB_NUKESENTINEL);

after a change to this, its all fine now:

Code:

@mail($admincontact[$i], $subject, $message, "From: " . $adminmail . "\r\nX-Mailer: " . _AB_NUKESENTINEL);

registered · Site Admin Joined: Jun 04, 2004 Posts: 6437

Good catch, neralex. But we only need to change the quote on the second string, since the first string contains no variables or special characters:

Code:

@mail($admincontact[$i], $subject, $message, 'From: ' . $adminmail . "\r\nX-Mailer: " . _AB_NUKESENTINEL);

Posted: Fri Oct 19, 2012 9:50 am

ok, good point. changed in my files!

Posted: Sat Oct 20, 2012 2:37 pm

If you can not find nukesentinel.php file then go to:

includes/nukesentinel.php

Thanks Neralex!