Form Problems

Client Joined: Oct 07, 2003 Posts: 735 Location: Ohio

Quote:

Sorry, such file doesn't exist...

is all I get from this. It is my 2nd attempt at an add(whatever) form. Am I not prosessing this right?

Code:

<?php


//////////////////////////////////////////////////////////////////////


//===========================


// MILPACS


//


// This is the Military Personell and Classification System.


// Donovan [3rd ID]


//


//


///////////////////////////////////////////////////////////////////////





/*********************************************************/


/* Add Soldier to MILPACS                                */


/*********************************************************/


if (!eregi("modules.php", $PHP_SELF)) {


   die ("You can't access this file directly...");


    }


$index = 0;





//finds the server's root directory


$self = dirname(__FILE__);


$nukemod = basename($self);


$rootdir = eregi_replace("/modules/$nukemod", "", $self);


require_once("mainfile.php");


include("header.php");


include("modules/MILPACS/db.inc.php");


$module_name = basename(dirname(__FILE__));


global $module_name, $db;  


  


   //If a soldier has been added, add them to the database





   if (isset($_POST['name']) and isset($_POST['rankname'])){


      $troop = $POST('name');


      $rank = $POST('rankname');


      $uniform = $POST('uniform');


      $location = $POST('location');


      $status = $POST('status');


      $p_mos = $POST('p_mos');


      $unit = $POST('unit');


      $reports = $POST('reports');


      $position = $POST('position');


      $weapon = $POST('weapon');


      $qual = $POST('qual');


      $enlistement_dt = $POST('enlistment_dt');


      $promotion_dt = $POST('promotion_dt');


      $icq = $POST('icq');


      $email = $POST('email');


      $bio = $POST('bio');


      





      $sql = @mysql_query("INSERT INTO milpacs_members SET name='$troop', uniform=$'uniform', location='$location', status='$status', p_mos='$p_mos', unit='$unit', reports='$reports', position='$position', weapon='$weapon', qual='$qual', enlistement_dt='$enlistment_dt', promotion_dt='$promotion_dt', icq='$icq', email='$email', bio='$bio'");





      if (@mysql_query($sql)) {


         echo "<p> The Soldier has been added to MLPACS!</p>";


      } else {


            echo "<p> Error adding Soldier!</p>";


         }


      }


    


    OpenTable();


   echo "<form name=\"addsoldier\" method=\"post\" action=\"<?php echo $_SERVER[PHP_SELF];?>";


    echo "<table border=\"2\" cellpadding=\"2\" align =\"center\" cellspacing=\"0\" style=\"border-collapse: collapse\" bgcolor=\"#000000\" bordercolor=\"#111111\" width=\"100%\"><tr>"


  . "         <td align=\"center\" bgcolor=\"#777777\">"


  . "            <b><font color=\"#000000\">Add a New Soldier</font></b>"


  . "         </td>"


  . "      <tr>"


  . "         <td align=\"center\" bgcolor=\"#777777\">Soldiers Name: <input type=\"text\" name=\"name\">"           


  . "         </td>"


  . "      </tr>"


  . "      </tr>      <tr>"


  . "         <td align=\"center\" bgcolor=\"#777777\"> Uniform image <input type=\"text\" name=\"uniform\">"        


  . "         </td>"


  . "      </tr>      <tr>"


  . "         <td align=\"left\" bgcolor=\"#666633\">"


  . "            <b><font color=\"#000000\">Vital Statistics</font></b>"


  . "         </td>"


  . "      </tr>      <tr>"


  . "         <td align=\"center\" bgcolor=\"#999999\">"


  . "            <table border=\"1\" cellpadding=\"2\" cellspacing=\"1\" "


  . "               style=\"border-collapse: collapse\" width=\"100%\" "


  . "               id=\"AutoNumber1\" bordercolor=\"#111111\">"


  . "               <tr>";


  //Drop down box to select a rank


  $ranks = @mysql_query("SELECT rank_id, rankname FROM milpacs_ranks ORDER by rank_id");


  if (!$ranks) {


     exit(


         '<p> Unable to obtain rank list from database.</p>');


            }


echo                  "<td width=\"10%\" align=\"center\">";


echo "<select rank=\"rank_id\" size=\"1\">";


echo "<option selected value=\"\">Select a Rank</option>";


echo " <option value=\"\">-------------</option>";


 while ($ranks = mysql_fetch_array($ranks)) {


    $id = $ranks["rank_id"];


    $rname = $ranks["rankname"];


echo "<option value='$id'>$rname</option>\n"


. "                     <br>";


 }


 


 echo"                  <input type=\"text\" name=\"rank\">"


  . "                     <br>"


  . "               </tr>"


  . "            </td>"


  . "               <tr>";


  //Drop down box for the flag


 $flags = @mysql_query("SELECT flag FROM milpacs_members");


  if (!$flags) {


     exit(


         '<p> Unable to obtain flag list from database.</p>');


            }


echo                  "<td width=\"10%\" align=\"center\">";


echo "<select flag=\"flag\" size=\"1\">";


echo "<option selected value=\"\">Select a Flag</option>";


echo " <option value=\"\">-------------</option>";


 while ($flags = mysql_fetch_array($flags)) {


    $flags = $flags["flag"];    


echo "<option value='$flag'>$flag</option>\n"


. "                     <br>";


 }


  echo"                  <input type=\"text\" name=\"flag\">"


   . "               </tr>"


  . "                  </td>" 


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Location:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"location\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Status:  </font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"status\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\">"


  . "                     <p align=\"right\"><font color=\"#660033\"><b>Primary MOS:</b></font>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"p_mos\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Unit:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"unit\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\">"


  . "                     <p align=\"right\"><font color=\"#660033\"><b>Reports to:</b></font>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"reports\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Position:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"position\">"


  . "                  </td>"


  . "               </tr>   "


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <font color=\"#660033\"><b>Weapon:</b></font>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"weapon\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\">"


  . "                     <p align=\"right\"><font color=\"#660033\"><b>Qualifications:</b></font>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"qual\">"


  . "                  </td>"


  . "               </tr>"


  . "                  "


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Enlisted Date:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"enlistement_dt\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">Promoted Date:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"promotion_dt\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">ICQ#:  </font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"icq\">"


  . "                  </td>"


  . "               </tr>"


  . "               <tr>"


  . "                  <td width=\"50%\" align=\"right\">"


  . "                     <b><font color=\"#660033\">E-mail:</font></b>"


  . "                  </td>"


  . "                  <td width=\"50%\">"


  . "                     <input type=\"text\" name=\"email\ size=\"25\ maxlength=\"25\">"


  . "                  </td>"


  . "               </tr>"  


  . "         </td>"


  . "      </tr>"


  . "      </table";


  echo"       <table>"


  . "        <tr>"


  . "          <td align=\"left\" bgcolor=\"#666633\">"


  . "            <b><font color=\"#000000\">Personal Bio</font></b>"


  . "          </td>"


  . "        </tr>"


  . "       <tr>"


  . "          <td align=\"left\" bgcolor=\"#999999\">"


  . "         <textarea name=\"bio\" cols=\"130\" colspan=\"1\" rows=\"12\"></textarea>"            


  . "          </td>"


  . "       </tr>"  


  . "      </table>";


  echo      "<br>";


  echo "  <input type=\"submit\" align=\"center\" name=\"Submit\" value=\"Add\"/>";


  echo "</form>";


  CloseTable();


  include("footer.php");


?>

Subject Matter Expert Joined: Feb 23, 2004 Posts: 358

Try:

replacing

Code:

   echo "<form name=\"addsoldier\" method=\"post\" action=\"<?php echo $_SERVER[PHP_SELF];?>";

with

Code:

   echo "<form name=\"addsoldier\" method=\"post\" action=\"modules.php?name=MILPACS&amp;file=addsoldier";

Now that's an example of a remote 'receiving' script; one that's seperate and named differently from the script sending the form. If the form comes from an index.php within the module itself, then you'd do

Code:

   echo "<form name=\"addsoldier\" method=\"post\" action=\"modules.php?name=MILPACS";

Hopefully one of those formats will get your form received... it has to go through modules.php.

Also, looking through your code (and was the case in this little bit of code), you seem to use variables anywhere possible instead where necessary. A variable only needs to be used when the URL (in this case) would change or need to be dynamic. In the case of a form, the receiving script should always be the same, so there's no need for a variable reference to it, just type it right on in as action=modules.php?whatever...!

Along these lines, always try to use static content whenever possible. Even force static content when it will eventually become dynamic. Why? Because you're building things... unexpected variable behavior can take a sane man to his knees in mere seconds. It's always better to write with static content and ensure the program is doing what's expected, then you can add in variables so the program can change depending on need.

If the above 'fix' for you isn't working as expected, let me know the exact name of the script that is sending the form, and the exact name of the script receiving the POST.

- PHrEEk

Posted: Sat Feb 19, 2005 6:14 pm

One other thing that may be causing a problem:

Code:

   echo "<form name=\"addsoldier\" method=\"post\" action=\"<?php echo $_SERVER[PHP_SELF];?>";

Your inline php open/close statement doesn't make sense since you're already within an open php tag (<?php at the top of the script). You only use an inline like this within a pure html doc, like ie.

Code:

<?php 


////////////////////////////////////////////////////////////////////// 


//=========================== 


// MILPACS 


// 


// This is the Military Personell and Classification System. 


// Donovan [3rd ID] 


// 


// 


/////////////////////////////////////////////////////////////////////// 





/*********************************************************/ 


/* Add Soldier to MILPACS                                */ 


/*********************************************************/ 


if (!eregi("modules.php", $PHP_SELF)) { 


   die ("You can't access this file directly..."); 


    } 


$index = 0; 





//finds the server's root directory 


$self = dirname(__FILE__); 


$nukemod = basename($self); 


$rootdir = eregi_replace("/modules/$nukemod", "", $self); 


require_once("mainfile.php"); 


include("header.php"); 


include("modules/MILPACS/db.inc.php"); 


$module_name = basename(dirname(__FILE__)); 


global $module_name, $db;  





etc etc... (this is all within PHP)





then...


?> (we shut off php, no need for echo now)





<form name="addsoldier" method="post" action="modules.php?name=whatever">


<table border="2" cellpadding="2" align ="center" cellspacing="0" style="border-collapse: collapse" bgcolor="#000000" bordercolor="#111111" width="100%">


  <tr>


    <td align="center" bgcolor="#777777">"


      <b><font color="#000000">Add a New Soldier</font></b>


    </td>


  </tr>


  <tr>


    <td align="center" bgcolor="#777777">Soldiers Name: <input type="text" name="name"></td>


  </tr>





etc etc...





<?php (we turn php back on if we need to)





more code yadda yadda





?> END OF SCRIPT

Whenever php hits a php close tag, it begins treating any other code afterwards as html, so there's no need to escape quotes, use echos or add semi-colons. Many authors work in this way, mixing php and html. In the above example then, if bgcolor was defined as a variable (which it is according to Nuke's theme system), you could use an inline php statement for just that one variable, ie.

Code:

<form name="addsoldier" method="post" action="modules.php?name=whatever">


<table border="2" cellpadding="2" align ="center" cellspacing="0" style="border-collapse: collapse" bgcolor="<?php echo"$bgcolor2"; ?>" bordercolor="#111111" width="100%">

There's so many styles and options available when coding, but professional php coders stay away from this type of inline use unless it's absolutely necessary. Yes, it's much easier, when you have a huge block of html formatting going out, to just shut off php and let the html flow... less hassle with escapes, etc... but if the html block of code has more than one or two variables in it, it's best to keep it in php and echo it out.

At any rate.. the code you posted does this: an open php tag, php code going out, then you open php -again-, then close it. The rest of your code after the close php is not being processed by php, and therefore the second (and final) closing php tag is meaningless.

PHrEEk

Posted: Sun Feb 20, 2005 10:51 am

Thank PHrEEk,

I am far from being a "professional". Mostly learning as I go and making my fair share of mistakes along the way. I live by the rule that you wont learn it if you don't do it, and you lose it if you don't use it.

Another question for you...

I have an editsoldier form that display the members name at the top correctly but does not display any of the information for that soldier. What control do you use to display members information?

Code:

 echo "<form>";


   echo "<p><a href=\"admin.php?op=milpacs\">Return to Main Administration</a></p>"; 


    echo "<table border=\"2\" cellpadding=\"2\" align =\"center\" cellspacing=\"0\" style=\"border-collapse: collapse\" bgcolor=\"#000000\" bordercolor=\"#111111\" width=\"100%\"><tr>"


  . "         <td align=\"center\" bgcolor=\"#777777\">"


  . "            <b><font color=\"#000000\">Personnel File of $info[name]</font></b>"


  . "         </td>"


  . "      </tr>      <tr>"


  . "         <td align=\"center\" bgcolor=\"#777777\"> Uniform image <input type=\"text\" name=\"uniform\">"            


  . "         </td>"


  . "      </tr>

$info[name] display the name of the member from my members table cause I passed the "id" to the editsoldier page but the text box "uniform" is empty. What variable do I use to display what uniform graphic is in the image/uniform/ directory for that member? Would it be something like <input type=\"text\" $info[uniform]>".

Thanks for all your help.

Posted: Sun Feb 20, 2005 11:00 am

This doesn't seem to work.

Code:

. "         <td align=\"center\" bgcolor=\"#777777\"> Uniform image: <input type=\"text\" <name=\"uniform\" $info[uniform]>"

Posted: Sun Feb 20, 2005 11:06 am

Nevermind.. Smile

The lightbulb over my head went off.

Code:

value=\" $info[uniform]\">"