link rel wrong link in forums [solved]

Posted: Sat Nov 19, 2005 5:11 pm

After a lot of changes in the last 3 weeks and upgrade to 2.0.17 I checked my forums.html today with the spider view. I found some links where I got "Sorry, such file doesn´t exist". I logged in and checked all my links in the forums again but there are no death links. However this are the links from the source code:

Quote:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta http-equiv="Content-Style-Type" content="text/css">

<link rel="top" href="forums.html?amp;file=modules&name=Forums&file=modules/Forums/index" title="mysite Foren-Übersicht" />

<link rel="search" href="forums.html?amp;file=modules&name=Forums&file=modules/Forums/search" title="Suchen" />
<link rel="help" href="forums.html?amp;file=modules&name=Forums&file=modules/Forums/faq" title="FAQ" />
<link rel="author" href="forums.html?amp;file=modules/Forums/modules&name=Members_List&file=index" title="Mitgliederliste" />

Only the last link rel"author" to memberlist works. I´don´t know since when I have these wrong links there. In wich file can I change this ?

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Check includes/page_header.php and includes/page_header_review.php. There's a dynamic routine that looks like this

Code:

//


// Generate HTML required for Mozilla Navigation bar


//


$nav_links_html = '';


$nav_link_proto = '<link rel="%s" href="%s" title="%s" />' . "\n";


while( list($nav_item, $nav_array) = @each($nav_links) )


{


   if ( !empty($nav_array['url']) )


   {


      $nav_links_html .= sprintf($nav_link_proto, $nav_item, append_sid($nav_array['url']), $nav_array['title']);


   }


   else


   {


      // We have a nested array, used for items like <link rel='chapter'> that can occur more than once.


      while( list(,$nested_array) = each($nav_array) )


      {


         $nav_links_html .= sprintf($nav_link_proto, $nav_item, $nested_array['url'], $nested_array['title']);


      }


   }


}

Posted: Sun Nov 20, 2005 9:08 am

Thanks,
I found the code in both files.
I´ve checked nukecops.com and some other sites. So I found the difference between my links and the others.
For example link rel "search":

Code:







<link rel="search" href="forums.html?file=modules&name=Forums&file=modules/Forums/search" title="Search" />

goes to:nukecops.com/modules.php?name=Forums&file=search

our link rel"search" is the same but it goes to:

http://www.mysite.com/modules.php?name=Forums&file=modules&name=Forums&file=modules/Forums/search
instead of:
http://www.mysite.com/modules.php?name=Forums&file=search

I guess there is no way to repair this I can only comment out the code.

registered · Posted: Sun Nov 20, 2005 8:38 pm

Perhaps this will help: http://www.nukefixes.com/ftopict-1287-link.html+rel

Posted: Mon Nov 21, 2005 4:34 am

Thanks ! This solved my problem in 2.0.17. Very Happy

My nice links:

Quote:

registered · Posted: Tue Nov 22, 2005 7:44 pm

Evaders99 wrote:

Perhaps this will help: http://www.nukefixes.com/ftopict-1287-link.html+rel

Evaders99 wrote:

Wondered why I was getting warnings from Admin Secure, this is why.
I don't think this has been updated in the Patched files, maybe it was looked over.
chatserv, will it be added into the next release of BBToNuke or Patched?

Hrm...

Indeed, it appears that this problem has been fixed in the 2.0.18 version of 'includes/functions.php', plus a couple of other things. In addition to the changes listed in that thread:

In the 2.0.17 version of 'includes/functions.php', you should...

Around line 341, change:

Code:

$default_style=$get_info[config_value];

To:

Code:

$default_style=$get_info['config_value'];

Around line 565, change:

Code:

$orig_word[] = '#\b(' . str_replace('\*', '\w*?', phpbb_preg_quote($row['word'], '#')) . ')\b#i';

To:

Code:

$orig_word[] = '#\b(' . str_replace('\*', '\w*?', preg_quote($row['word'], '#')) . ')\b#i';

Posted: Tue Nov 22, 2005 7:49 pm

I must be going blind because your line 341 From and To line appear to be the same?

Posted: Tue Nov 22, 2005 7:51 pm

config_value has single-quotes around it... Wink

Posted: Tue Nov 22, 2005 8:01 pm

- Now if this was not on that post Last edited by VinDSL on Tue Nov 22, 2005 7:49 pm; edited 1 time in total then you'd convince me I missed that Wink

Posted: Tue Nov 22, 2005 10:19 pm

Sorry! That information is available on a circumspect “need to know basis” only.

I could tell you, but (you know the rest)... Mr. Green

Posted: Wed Nov 23, 2005 7:10 pm

Thanks VinDSL

I changed the lines in the functions.php too.
And thanks to Chatserv found a fix for my posting problem with update_points in 2.017. Smile