Ravens PHP Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> BBtoNuke
Author Message
hitwalker
Sells PC To Pay For Divorce



Joined:
Posts: 5661

PostPosted: Wed Jul 05, 2006 1:17 am Reply with quote

i just noticed something weird..
since the forum upgrade it changes
Code:
 
to
Code:
; ;

So you cant put something simple like that inside codetags anymore?
anyway to change that ...

(btw on this forum it doesnt change..)

and why does it change this...


Code:


<table border="0" width="100%">
<tr>
<td width="106">Rank</td>
<td width="203">username</td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
</table>




into this.....


Code:


<table>
<tr>
<td>Rank</td>
<td>username</td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
</table>



look at image tags...


Last edited by hitwalker on Wed Jul 05, 2006 2:40 pm; edited 1 time in total 
View user's profile Send private message
kguske
Site Admin



Joined: Jun 04, 2004
Posts: 6437

PostPosted: Wed Jul 05, 2006 5:38 am Reply with quote

Just to clarify, which version of phpBB are you using?

_________________
I search, therefore I exist...
Only registered users can see links on this board! Get registered or login!
 
View user's profile Send private message
hitwalker







PostPosted: Wed Jul 05, 2006 5:41 am Reply with quote

newest ...
i never had this before...
i dont use the codetags that much so i didnt noticed it sooner..
but i hear more weird things happening suddenly from other people...
even here with ravens forum i noticed some weird behaviour with the code tags when i put some code in it...

but how to solve this cause cleaning out a img tag is complete new to me..
 
kguske







PostPosted: Wed Jul 05, 2006 5:58 am Reply with quote

Do you have any other forum mods?
 
hitwalker







PostPosted: Wed Jul 05, 2006 6:10 am Reply with quote

...eh lets see...
a simple link one...google it...
grabs the topic and google it...
just a few lines...


the Recent Topics (glance) ..

the spellcheck....
but i have that for a long time now...
files weren't effected when did forum upgrade.

and added the mod quick reply.....

but i can tell you tell the img tag is stripped as soon as i click preview..
going from :
Code:
<img border="0" src="whatever.jpg">

to
Code:
<img>


bit weird dont you think...
 
hitwalker







PostPosted: Wed Jul 05, 2006 6:25 am Reply with quote

i took out the quick reply again....i never use it..
makes no difference.
 
hitwalker







PostPosted: Wed Jul 05, 2006 6:30 am Reply with quote

we know more....
it doesnt matter if i use the code tags or not,with the img tag its stripped in any way.
 
hitwalker







PostPosted: Wed Jul 05, 2006 1:07 pm Reply with quote

nobody knows?
 
Guardian2003
Site Admin



Joined: Aug 28, 2003
Posts: 6799
Location: Ha Noi, Viet Nam

PostPosted: Wed Jul 05, 2006 3:09 pm Reply with quote

Just a quick experiment....
In includes/functions_post.php
Find
Code:
foreach ($message_split as $part)

                {
         $tag = array(array_shift($matches[0]), array_shift($matches[1]), array_shift($matches[2]));
         $message .= preg_replace($html_entities_match, $html_entities_replace, $part) . clean_html($tag);
                }

      $message = addslashes($message);

Try relpacing that with
Code:
foreach ($message_split as $part)

                {
         $tag = array(array_shift($matches[0]), array_shift($matches[1]), array_shift($matches[2]));
         $message .= htmlspecialchars($part) . clean_html($tag);
                }

      $message = addslashes($message);

Try posting with that code but without using the preview function (I'm still trying to find that bit).
 
View user's profile Send private message Send e-mail
hitwalker







PostPosted: Wed Jul 05, 2006 3:23 pm Reply with quote

nope.... Sad
its the same...
 
Captain_Computer
Hangin' Around



Joined: May 30, 2004
Posts: 46

PostPosted: Wed Jul 05, 2006 4:18 pm Reply with quote

I don't know what upgrade caused this problem. Either .20 or .21 upgrade introduced this problem. I just upgraded 3 sites today from .19 to .21 and have the same problem.

To enable the code to display correctly, after entering your post check the box 'Disable HTML in this post' and it will work.

Updated:

Or in General configuration, check the 'No' box for 'Allow HTML'. Then it will work all the time. But the 'Disable HTML in this post' will not appear in the posting section.

_________________
Captain Computer Said It !!!!

Last edited by Captain_Computer on Wed Jul 05, 2006 4:26 pm; edited 1 time in total 
View user's profile Send private message Visit poster's website
hitwalker







PostPosted: Wed Jul 05, 2006 4:26 pm Reply with quote

that works as a temp solution..but naturaly i want this fixed as it should work properly..
so you have it to.... Sad
if thats the case then more people should have this problem...
 
Guardian2003







PostPosted: Wed Jul 05, 2006 5:22 pm Reply with quote

I'll try to look into this some more tomorrow Hit.
I think the issue is with the x.x.21 update but finding exactly where may take some time.
 
hitwalker







PostPosted: Wed Jul 05, 2006 6:49 pm Reply with quote

thats ok guardian...
i hope that others are investigating this to....
 
Dauthus
Worker
Worker



Joined: Oct 07, 2003
Posts: 211

PostPosted: Sat Jul 08, 2006 10:11 pm Reply with quote

This may sound kind of simple, but did you try adding the img and &nbsp; tags to the allowed HTML in the Forum => Admin => General Admin => User And Forum Basic Settings?

It looks like the 2.0.21 upgrade strips out any additional parameters for html that isn't included there. Even if you try and place it inside the quote and/or code BBCode. (Security?)

I haven't upgraded so I am not positive this is the problem.

_________________
Only registered users can see links on this board! Get registered or login!
Vivere disce, cogita mori 
View user's profile Send private message Visit poster's website
hitwalker







PostPosted: Sun Jul 09, 2006 4:49 am Reply with quote

Why should i add it ?
maybe the people behind the updates should be more carefull and not to mess things up to much...
thousands of people rely on these script updates so the responsibility is huge...but easy to forget..
 
Dauthus







PostPosted: Sun Jul 09, 2006 10:41 am Reply with quote

I thought you were trying to find a solution to the tag problem. I take it you were just wanting to rant?
 
hitwalker







PostPosted: Sun Jul 09, 2006 1:07 pm Reply with quote

no whatever gave you that idea....
im just saying how it is,there are thousand workarounds for this but im not interested in that.
 
evaders99
Former Moderator in Good Standing



Joined: Apr 30, 2004
Posts: 3221

PostPosted: Sun Jul 09, 2006 10:47 pm Reply with quote

Its definitely being introduced in the later phpBBs. The code filtering is trying to stop abuse, but it is changing people's valid HTML code. I don't know when we'll see a fix for it

_________________
- Only registered users can see links on this board! Get registered or login! -

Need help? Only registered users can see links on this board! Get registered or login! 
View user's profile Send private message Visit poster's website
hitwalker







PostPosted: Mon Jul 10, 2006 4:32 am Reply with quote

well it seems to be ok here at ravens.....
these are just simple tags....
it proves more and more that its absolutely NOT adviced to use an update when its released.
think these things shouldnt happen.....securing a board thats fine but taking away it functionaly or causing problems with its use it unacceptable.
 
Display posts from previous:       
Post new topic   Reply to topic    Ravens PHP Scripts And Web Hosting Forum Index -> BBtoNuke

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 6 Hours
 
Forums ©