Stories Archive module page numbers function never end

Hangin' Around Joined: Nov 26, 2005 Posts: 40

Hello,

I hope here someone who knows php programming, I am not so advanced.. Sad

in Stories Archive module possible to change number of stories on page, "by default " it is 250.... So if you have 600 stories it should be 3 pages ... 1 and 2 pages 250 stories per page and 3 page 100 stories and normaly on the 3 page we don't find next link only previuos link...

BUT SOMETHING WRONG IN CODE ! The NEXT LINK never stop.

here is code in index.php of Stories_Archive module .... function show_all

-----------
function show_all($min) {
global $prefix, $user_prefix, $db, $bgcolor1, $bgcolor2, $user, $cookie, $sitename, $multilingual, $language, $module_name, $userinfo;
if (!isset($min) || intval($min) <= 0) {
$min = 0;
}
else $min = intval($min);
$max = 250;
include("header.php");
title(""._STORIESARCHIVE."");.................................
.............................................

$a = 0;
if (($numrows > 250) AND ($min == 0)) {
$min = $min+250;
$a++;
echo "<center>[ <a href=\"modules.php?name=$module_name&sa=show_all&min=$min\">"._NEXTPAGE."</a> ]</center><br>";
}
if (($numrows > 250) AND ($min >= 250) AND ($a != 1)) {
$pmin = $min-250;
$min = $min+250;
$a++;
echo "<center>[ <a href=\"modules.php?name=$module_name&sa=show_all&min=$pmin\">"._PREVIOUSPAGE."</a> | <a href=\"modules.php?name=$module_name&sa=show_all&min=$min\">"._NEXTPAGE."</a> ]</center><br>";
}
if (($numrows <= 250) AND ($a != 1) AND ($min != 0)) {
$pmin = $min-250;
echo "<center>[ <a href=\"modules.php?name=$module_name&sa=show_all&min=$pmin\">"._PREVIOUSPAGE."</a> ]</center><br>";
}...............................
...........................
-----------------------

Help please..... to fix !
Thnks

registered · Posted: Thu Oct 26, 2006 7:54 am

Yeah, this logic is definitely broken. Let me see what I can do... I will have to look at this tomorrow morning.

Posted: Thu Oct 26, 2006 6:29 pm

Ok, I have found the fix and have also fixed this for the upcoming RavenNuke 2.10.00 release. I modified the code as such:

Code:




    $a = 0;


    if (($numrows > $max) AND ($min == 0)) {


        $min = $min+$max;


        $a++;


        echo '<center>[ <a href="modules.php?name='.$module_name.'&amp;sa=show_all&amp;min='.$min.'">'._NEXTPAGE.'</a> ]</center><br />';


    }


    if (($numrows > $max) AND ($min < $numrows-$max) AND ($a == 0)) {


        $pmin = $min-$max;


        $min = $min+$max;


        $a++;


        echo '<center>[ <a href="modules.php?name='.$module_name.'&amp;sa=show_all&amp;min='.$pmin.'">'._PREVIOUSPAGE.'</a> | <a href="modules.php?name='.$module_name.'&amp;sa=show_all&amp;min='.$min.'">'._NEXTPAGE.'</a> ]</center><br />';


    }


    if (($numrows > $max) AND ($a == 0) AND ($min != 0)) {


        $pmin = $min-$max;


        echo '<center>[ <a href="modules.php?name='.$module_name.'&amp;sa=show_all&amp;min='.$pmin.'">'._PREVIOUSPAGE.'</a> ]</center><br />';


    }

This way, whatever you end up changing the $max = 250; variable to up above, it works properly.