Downloads(rate it from your web site)

Worker Joined: Dec 05, 2006 Posts: 180

When clicking on "Rate Resource" at the bottom there is
"Is this your resource? Allow other users to rate it from your web site!".
Clicking on that... Only registered users can see links on this board! Get registered or login!

Not sure if this is a bug or an error on my part. This also happens at ravennuke.com

The referral link created is missing the $site url or whatever it is defined as. So links look like this

<a href="//modules.php?name=Downloads&d_op=ratedownload&lid=2">Rate this Resource</a>

The button link seems to work on both sites(mine and ravennuke). Although Raven, when clicking the button link on ravennuke.com i get an error:
Notice: Undefined variable: ttitle in /home/ravennuk/public_html/modules/Downloads/index.php on line 115

Im not sure how these links are supposed to work. If they are supposed to be put to use on another site or the site the download is on.

Posted: Mon Mar 19, 2007 5:02 am

Thanks, I´ll add this to our bug tracker.
You are right this option is supposed to be put to use on another site.
This feature is seldom used but the link should look like this:

<a href="http://www.siteurl/modules.php?name=Downloads&d_op=ratedownload&lid=2">Rate this Resource</a>

Posted: Mon Mar 19, 2007 5:13 am

cool

Posted: Mon Mar 19, 2007 6:52 am

This feature seems to be generating the correct link for me.

Please can you confirm if you have specified a Site Url in your Web Site Configuration?

Posted: Mon Mar 19, 2007 3:05 pm

it work for weblinks for me but not downloads. Yeah i have a siet url set, are you looking in downloads?

Posted: Mon Mar 19, 2007 3:13 pm

Ah yes you are right, I was looking in Web links, not having a good day! Bang Head

Posted: Mon Mar 19, 2007 3:19 pm

Posted: Mon Mar 19, 2007 7:59 pm

I'll take a look at the ratedownload function

Posted: Sun Mar 25, 2007 7:28 am

<bump>

registered · Posted: Sun Mar 25, 2007 9:17 am

BTW, I just assigned this issue to Guardian in our bug tracker... Wink

Posted: Sun Mar 25, 2007 2:46 pm

This is what I did. Someone tell me if im wrong.

modules/Downloads/index.php

Find all:

Code:




="'.NUKE_BASE_FOLDER.'

Replace all with:

Code:




="'.$nukeurl.'/

Posted: Mon Mar 26, 2007 6:31 am

You say "Find all", which concerns me. Those two are completely different things. It is possible that this was a mistake in that one area for the URL only, but I would only make that change in that one place... Lets see also what Guardian comes up with.

Posted: Mon Mar 26, 2007 6:36 am

there might be one that doesnt need changed, but i dont know.

Posted: Mon Mar 26, 2007 8:51 am

The fix proposed by jjh221 is correct but it should ONLY be applied to the function 'outsidedownloadsetup' which starts around line 1953

The existing code uses the constant NUKE_BASE_FOLDER which only has a value if nuke is installed in a sub-directory (the value is that of the sub-directory name). As we need to use a full path for external form processing, nukes existing global variable $nukeurl is the perfect choice.

I have tested the changes and am submitting them to CVS now.

[Internal Ref: Mantis 0000642 / Build 1387]