Slashes in Feedback Email

registered · Posted: Sat Mar 31, 2007 10:45 am

My host has magic quotes turned on. I was getting feedback emails with slashes in them.

I changed this line

Code:




$message = htmlentities($message);

to this:

Code:




$message = htmlentities(stripslashes($message), ENT_NOQUOTES);

I also decided to add ENT_NOQUOTES to keep the quotes from being converted to entities to make it more readable. Season to taste. Wink

Posted: Sun Apr 01, 2007 7:40 am

Nice one!
Could we not employ some test to see if magic quotes is on so that line is altered automagically?

Posted: Sun Apr 01, 2007 10:09 am

Sure, but the rest of the code was unconditionally stripslashing the other form fields, so I just did the same.

In GCalender I used a slightly modified version of that InputFilter class that was on the web a while back (seems to be gone now). In "the next CMS" it would be nice to have a global object of that class around (like the db object) that modules can grab to do filtering, etc.

registered · Posted: Sun Apr 01, 2007 10:26 am

Agreed in that the code is indiscriminate. Although that replacement Feedback module is newer than the original PHP-Nuke one (and MUCH more secure), it could be improved upon.

Since you have phrased this thread as "Feedback", should we move this to the Enhancements RN forum? Otherwise, I'd suggest making the title specific to the issue of seeing slashes in the feedback.

Posted: Sun Apr 01, 2007 11:09 am

Good idea, I changed the subject of this thread accordingly.