Author |
Message |
hitwalker
Sells PC To Pay For Divorce
Joined:
Posts: 5661
|
Posted:
Wed Jul 05, 2006 1:17 am |
|
i just noticed something weird..
since the forum upgrade it changes to
So you cant put something simple like that inside codetags anymore?
anyway to change that ...
(btw on this forum it doesnt change..)
and why does it change this...
Code:
<table border="0" width="100%">
<tr>
<td width="106">Rank</td>
<td width="203">username</td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
<tr>
<td width="106"><img border="0" src="whatever.jpg"></td>
<td width="203"></td>
<td></td>
</tr>
</table>
|
into this.....
Code:
<table>
<tr>
<td>Rank</td>
<td>username</td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
<tr>
<td><img></td>
<td></td>
<td></td>
</tr>
</table>
|
look at image tags... |
Last edited by hitwalker on Wed Jul 05, 2006 2:40 pm; edited 1 time in total |
|
|
|
kguske
Site Admin
Joined: Jun 04, 2004
Posts: 6437
|
Posted:
Wed Jul 05, 2006 5:38 am |
|
Just to clarify, which version of phpBB are you using? |
_________________ I search, therefore I exist...
Only registered users can see links on this board! Get registered or login! |
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 5:41 am |
|
newest ...
i never had this before...
i dont use the codetags that much so i didnt noticed it sooner..
but i hear more weird things happening suddenly from other people...
even here with ravens forum i noticed some weird behaviour with the code tags when i put some code in it...
but how to solve this cause cleaning out a img tag is complete new to me.. |
|
|
|
|
kguske
|
Posted:
Wed Jul 05, 2006 5:58 am |
|
Do you have any other forum mods? |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 6:10 am |
|
...eh lets see...
a simple link one...google it...
grabs the topic and google it...
just a few lines...
the Recent Topics (glance) ..
the spellcheck....
but i have that for a long time now...
files weren't effected when did forum upgrade.
and added the mod quick reply.....
but i can tell you tell the img tag is stripped as soon as i click preview..
going from :
Code:<img border="0" src="whatever.jpg">
|
to
bit weird dont you think... |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 6:25 am |
|
i took out the quick reply again....i never use it..
makes no difference. |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 6:30 am |
|
we know more....
it doesnt matter if i use the code tags or not,with the img tag its stripped in any way. |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 1:07 pm |
|
|
|
|
Guardian2003
Site Admin
Joined: Aug 28, 2003
Posts: 6799
Location: Ha Noi, Viet Nam
|
Posted:
Wed Jul 05, 2006 3:09 pm |
|
Just a quick experiment....
In includes/functions_post.php
Find
Code:foreach ($message_split as $part)
{
$tag = array(array_shift($matches[0]), array_shift($matches[1]), array_shift($matches[2]));
$message .= preg_replace($html_entities_match, $html_entities_replace, $part) . clean_html($tag);
}
$message = addslashes($message);
|
Try relpacing that with
Code:foreach ($message_split as $part)
{
$tag = array(array_shift($matches[0]), array_shift($matches[1]), array_shift($matches[2]));
$message .= htmlspecialchars($part) . clean_html($tag);
}
$message = addslashes($message);
|
Try posting with that code but without using the preview function (I'm still trying to find that bit). |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 3:23 pm |
|
nope....
its the same... |
|
|
|
|
Captain_Computer
Hangin' Around
Joined: May 30, 2004
Posts: 46
|
Posted:
Wed Jul 05, 2006 4:18 pm |
|
I don't know what upgrade caused this problem. Either .20 or .21 upgrade introduced this problem. I just upgraded 3 sites today from .19 to .21 and have the same problem.
To enable the code to display correctly, after entering your post check the box 'Disable HTML in this post' and it will work.
Updated:
Or in General configuration, check the 'No' box for 'Allow HTML'. Then it will work all the time. But the 'Disable HTML in this post' will not appear in the posting section. |
_________________ Captain Computer Said It !!!!
Last edited by Captain_Computer on Wed Jul 05, 2006 4:26 pm; edited 1 time in total |
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 4:26 pm |
|
that works as a temp solution..but naturaly i want this fixed as it should work properly..
so you have it to....
if thats the case then more people should have this problem... |
|
|
|
|
Guardian2003
|
Posted:
Wed Jul 05, 2006 5:22 pm |
|
I'll try to look into this some more tomorrow Hit.
I think the issue is with the x.x.21 update but finding exactly where may take some time. |
|
|
|
|
hitwalker
|
Posted:
Wed Jul 05, 2006 6:49 pm |
|
thats ok guardian...
i hope that others are investigating this to.... |
|
|
|
|
Dauthus
Worker
Joined: Oct 07, 2003
Posts: 211
|
Posted:
Sat Jul 08, 2006 10:11 pm |
|
This may sound kind of simple, but did you try adding the img and tags to the allowed HTML in the Forum => Admin => General Admin => User And Forum Basic Settings?
It looks like the 2.0.21 upgrade strips out any additional parameters for html that isn't included there. Even if you try and place it inside the quote and/or code BBCode. (Security?)
I haven't upgraded so I am not positive this is the problem. |
_________________ Only registered users can see links on this board! Get registered or login!
Vivere disce, cogita mori |
|
|
|
hitwalker
|
Posted:
Sun Jul 09, 2006 4:49 am |
|
Why should i add it ?
maybe the people behind the updates should be more carefull and not to mess things up to much...
thousands of people rely on these script updates so the responsibility is huge...but easy to forget.. |
|
|
|
|
Dauthus
|
Posted:
Sun Jul 09, 2006 10:41 am |
|
I thought you were trying to find a solution to the tag problem. I take it you were just wanting to rant? |
|
|
|
|
hitwalker
|
Posted:
Sun Jul 09, 2006 1:07 pm |
|
no whatever gave you that idea....
im just saying how it is,there are thousand workarounds for this but im not interested in that. |
|
|
|
|
evaders99
Former Moderator in Good Standing
Joined: Apr 30, 2004
Posts: 3221
|
Posted:
Sun Jul 09, 2006 10:47 pm |
|
Its definitely being introduced in the later phpBBs. The code filtering is trying to stop abuse, but it is changing people's valid HTML code. I don't know when we'll see a fix for it |
_________________ - Only registered users can see links on this board! Get registered or login! -
Need help? Only registered users can see links on this board! Get registered or login! |
|
|
|
hitwalker
|
Posted:
Mon Jul 10, 2006 4:32 am |
|
well it seems to be ok here at ravens.....
these are just simple tags....
it proves more and more that its absolutely NOT adviced to use an update when its released.
think these things shouldnt happen.....securing a board thats fine but taking away it functionaly or causing problems with its use it unacceptable. |
|
|
|
|
|