if elseif logic

Client Joined: Oct 07, 2003 Posts: 735 Location: Ohio

I have scores from a match I want to reconcile and deduct points from the losing team. The match scores were 7-6. The script is below.

Code:

if ($op == "ReconcileMatch") {   


   $game_id = $_POST['game_id'];


   $winner = $_POST['winner'];


   $loser = $_POST['loser'];


   $team_id = $_POST['team_id'];


   $loserscores = $_POST['loserscores'];


   $winnerscores = $_POST['winnerscores'];





   if (($loserscores) >= 4){


   $r_points = '-1';


   }elseif(($loserscores) <= 3){ 


   $r_points = '-2';


      }else{


      $r_points = '-3';


      }

The losing score was 6 so the value should have been -1, but instead it was -2.

The logic is the worse the score was for the loser the more points are deducted from his total.

Don't know where I went wrong on this. I generate $r_points myself. It is not in any form.

Is there an easier way? Less chance of errors like this?

registered · Posted: Tue Jan 02, 2007 11:01 pm

The only way '-3' would get valued is if the value was in-between 3 and 4 but not inclusive. If these are integer values (as you have indicated), you need to losen up one of those conditions.

Posted: Tue Jan 02, 2007 11:16 pm

I also have it written like

Code:

if (4 >= $loserscores AND $loserscores <= 7){


   $r_points = '-1';


   }elseif(1 >= $loserscores AND $loserscores <= 3){ 


   $r_points = '-2';


      }else{


      $r_points = '-3';


      }

Posted: Wed Jan 03, 2007 12:19 am

montego wrote:

The only way '-3' would get valued is if the value was in-between 3 and 4 but not inclusive. If these are integer values (as you have indicated), you need to losen up one of those conditions.

Not following your post. I assign the negative numbers. I just need to find if the loserscore is between 7 or 4 if so then a -1 is assigned to r_points

If the loserscore is between 1 and 3 then -2

else -3

savy?

Posted: Wed Jan 03, 2007 6:16 am

My point is that look at each of your conditions. Where would "4" fall and where would "3" fall? Can $loserscores be anything in-between 3 and 4? I.e., a "real" value as apposed to an "integer"?

You are always using ">=" or "<=". why not trying to "lose the equal sign" on one of those (i.e., what I meant by "losening up one of the conditions".

Posted: Wed Jan 03, 2007 8:08 am

It would appear that this would be correct.

Code:

if (($loserscores) >= 4){ 


   $r_points = '-1'; 


   }elseif((($loserscores) <= 3) AND ($loserscores != 0)){ 


   $r_points = '-2'; 


      }else{ 


      $r_points = '-3'; 


      }

But a score of 3 is now giving me a -3 result when it should give me a -2.

Posted: Wed Jan 03, 2007 6:01 pm

Why would it?

3 is <= 3 AND it is != 0....

what am I missing?

Posted: Wed Jan 03, 2007 6:12 pm

I guess I'm the one missing something as you are far more experinced in this logic.

Explain to me...

if $loserscore = 3

and ($loserscores <= 3) is true

AND ($loserscores != 0) is true

then why would it not give me the result $r_points = -2?

See I only want it to give me $r_points = -3 when the $loserscore is 0

Posted: Wed Jan 03, 2007 6:28 pm

No, my fault. I reversed the two in my head. Does the following work:

Why not the following?

Code:




if ($loserscores >= 4) 


   $r_points = -1;


elseif (($loserscores < 4) && ($loserscores > 0))


   $r_points = -2;


else


   $r_points = -3;

Sorry for misunderstanding you ealier.

Posted: Wed Jan 03, 2007 6:39 pm

Donovan, I won't be back on the boards until either late tonight or early in the morning just so you know...

Posted: Wed Jan 03, 2007 8:36 pm

I think I may have found the problem. It may not be with the if else logic.

I can select a radio button on this forum, but when I process the script it doesn't insert the correct row of data to the database table. It inserts one of the other rows of data. I could probably put this into an array and submit all with checkboxes but I suck at arrays.

http://www.eto-league.com/MatchList.txt

My index.php contains this.

Code:

case "ReconcileMatch":


    reconcileMatch($game_id, $winner, $loser, $team_id, $loserscores, $winnerscores);


    break;

And then the function that inserts all the variables.

http://www.eto-league.com/reconcileMatch.txt

Scratching my head on this. Don't know why it would not pass the correct records.

Posted: Wed Jan 03, 2007 8:46 pm

What does the HTML code look like for this form? Each of the option input field should have the same name="xxxxx" and then the value, I would think, would be your ID?

Remember that echo and die() functions are your "friends".

Try echoing out your variables and then right before your first sql command, issue a:

die('got here');

Make sure the variables from the form are getting to this function properly.

Posted: Wed Jan 03, 2007 9:03 pm

montego wrote:

What does the HTML code look like for this form? Each of the option input field should have the same name="xxxxx" and then the value, I would think, would be your ID?

Here is what the html looks like.

Code:

<tr><td align="center" bgcolor="#666666"><font color="#000000">1</td><td align="center" bgcolor="#666666"><font color="#000000">Dec 4, 2006, 20:39</td><td align="center" bgcolor="#666666"><font color="#000000">3rd Infantry Division</td><td align="center" bgcolor="#666666"><font color="#000000">82nd Airborne 1</td><td align="center" bgcolor="#666666"><font color="#000000">7</td><td align="center" bgcolor="#666666"><font color="#000000">0</td><td align="center" bgcolor="#666666"><input type="radio" name="game_id" value="1"></td></tr>





<tr><td align="center" bgcolor="#666666"><font color="#000000">2</td><td align="center" bgcolor="#666666"><font color="#000000">Dec 7, 2006, 22:33</td><td align="center" bgcolor="#666666"><font color="#000000">1 GEBIRGSJAEGER DIVISION</td><td align="center" bgcolor="#666666"><font color="#000000">3rd Infantry Division</td><td align="center" bgcolor="#666666"><font color="#000000">7</td><td align="center" bgcolor="#666666"><font color="#000000">6</td><td align="center" bgcolor="#666666"><input type="radio" name="game_id" value="2"></td></tr>





<tr><td align="center" bgcolor="#666666"><font color="#000000">3</td><td align="center" bgcolor="#666666"><font color="#000000">Dec 9, 2006, 01:02</td><td align="center" bgcolor="#666666"><font color="#000000">UK Hitler Assassination Squad</td><td align="center" bgcolor="#666666"><font color="#000000">45th Infantry Division</td><td align="center" bgcolor="#666666"><font color="#000000">7</td><td align="center" bgcolor="#666666"><font color="#000000">3</td><td align="center" bgcolor="#666666"><input type="radio" name="game_id" value="3"></td></tr>





<tr><td><input type="submit" value="Reconcile"></td></tr><input type="hidden" name="team_id" value="121"><input name="op" type="hidden" value="ReconcileMatch""></table></form></TD>

Why would team_id listed near the end already have a value assigned?

I currently have this.

Code:

. "<td align=\"center\" bgcolor=\"#666666\"><input type=\"radio\" name=\"game_id\" value=\"$game_id\"></td>"

Posted: Wed Jan 03, 2007 10:33 pm

The HTML form code looks reasonable enough. Regarding this here:

Quote:

Why would team_id listed near the end already have a value assigned?

I can't tell you because you are not showing anywhere this line of code that is generating this. The code snippet you provided is for input field named "game_id", not "team_id".

I think you are going to have to dig on this one a bit using the techniques I mentioned above with echoes and the die() statement. Just what is getting into the function and what isn't and is it what you expect to see from what you selected on the page.

Posted: Sun Jan 07, 2007 10:07 pm

I posted this problem on another site and here is some feedback.

Quote:

You set team_id after the while loop so the value passed is the last value of team_id in the list. You correctly pass a correct value for game_id but you do not pass winner, loser, winnerscores and loserscores, but you use those last four variables when reconciling. All you need to pass is the game _id (I think) Then look up the values for that specific game_id inside your reconcile function then perform your reconciliation and updates inside the function.

I don't see how I am passing the correct game_id as the correct game_id is not getting reconciled. I can tell this from my UPDATE statement

Code:

"UPDATE " . $prefix . "_tc_playedgames SET reconciled ='1' WHERE game_id ='$game_id'";

Does not reconcile the correct game_id.

I could just pass game_id and then run my query in my function to INSERT all the other values if only I could get the correct game_id passed.

Posted: Sun Jan 07, 2007 11:33 pm

montego wrote:

I can't tell you because you are not showing anywhere this line of code that is generating this. The code snippet you provided is for input field named "game_id", not "team_id".

I think you are going to have to dig on this one a bit using the techniques I mentioned above with echoes and the die() statement. Just what is getting into the function and what isn't and is it what you expect to see from what you selected on the page.

Need to see more of the PHP code behind this. Need to see what is generating the form and then what is processing it.

Posted: Wed Jan 10, 2007 9:25 am

I finally fixed this by getting rid of the radio buttons and using links for each record. Radio buttons would not pass the correct game_id no matter what I did.